chore(deps): remove electron dependencies#141
Merged
Conversation
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
feloy
approved these changes
Jun 10, 2025
benoitf
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140.
I am not sure about why was electron included in root package.json. But is not imported in any module, so should be safe. Also, project is missing workspace setup similar to: https://github.com/podman-desktop/extension-bootc/blob/main/pnpm-workspace.yaml, setting pnpm version, etc. I that would be out of scope for this PR I think.
E2E tests should be passing with this patch. After we release next version of tests-playwright, we should switch to that version instead of minimal nightly for the package.