Skip to content

chore: don't show ENOENT error in console#498

Closed
SoniaSandler wants to merge 3 commits into
redhat-developer:mainfrom
SoniaSandler:macadam-error
Closed

chore: don't show ENOENT error in console#498
SoniaSandler wants to merge 3 commits into
redhat-developer:mainfrom
SoniaSandler:macadam-error

Conversation

@SoniaSandler

Copy link
Copy Markdown
Contributor

When calling macadam's listVms, if there is no macadam binary found, don't show the error in the console since it is done periodically, and the error spams the logs

Closes #473

Signed-off-by: Sonia Sandler <ssandler@redhat.com>
@SoniaSandler SoniaSandler requested review from a team and feloy as code owners March 30, 2026 16:02
@SoniaSandler SoniaSandler requested review from cdrage and vancura and removed request for a team March 30, 2026 16:02
@SoniaSandler SoniaSandler removed the request for review from vancura March 30, 2026 16:02
Signed-off-by: Sonia Sandler <ssandler@redhat.com>
Signed-off-by: Sonia Sandler <ssandler@redhat.com>

@cdrage cdrage left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do it similar to podman-desktop/extension-bootc#2419 ?

Since the main issue is that it continues to init.

I believe in this PR it just ignores the error instead of fixing the init?

@SoniaSandler

Copy link
Copy Markdown
Contributor Author

@cdrage @feloy this code already exists in the RHEL extension

async init(): Promise<void> {
await this.macadam.init();
this.#initialized = true;
this.#onMacadamInit.emit(SIGNAL);
}

There was no indication in the ticket regarding which OS it is, but now I see that in your bootc PR it's on Linux only.
This PR was supposed to solve what I was able to reproduce on macOS, which needed to have the macadam binary when starting, but then make it "disappear" (delete it after the extension started).
I'll also check on Linux, but since the solution from bootc already exists in the RHEL ext, I'll ping Rujuta to double check the OS and reproducing steps for this issue

@SoniaSandler SoniaSandler marked this pull request as draft April 1, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rhel vm logs are spamming console log with spawn errors when macadam is not installed

2 participants