feat: enhance type safety and error handling in extension#905
Open
dgolovin wants to merge 3 commits into
Open
Conversation
Fix redhat-developer#194. - Updated package.json to include a typecheck script. - Updated build script to include typecheck strp. - Improved type definitions in extension.spec.ts and extension.ts for better type safety. - Added error handling for missing context, cluster, and user in OpenShift functions. - Refactored functions to ensure undefined checks and proper error messages. - Enhanced the getSandboxAPIUrl function to return undefined when no URL is configured. Signed-off-by: Denis Golovin <dgolovin@redhat.com>
Assisted-by: <Cursor> Signed-off-by: Denis Golovin <dgolovin@redhat.com>
Assisted-by: <Cursor> Signed-off-by: Denis Golovin <dgolovin@redhat.com>
jeffmaury
reviewed
Jul 2, 2026
jeffmaury
left a comment
jeffmaury
left a comment
Member
There was a problem hiding this comment.
typecheck is performed not automatically in other places ?
Collaborator
Author
|
I added to build only, similar to SSO Extension to have it executed in CI without modifying GHA workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #194.