fix: use the same scopes for auth session as other extensions#906
Open
dgolovin wants to merge 1 commit into
Open
fix: use the same scopes for auth session as other extensions#906dgolovin wants to merge 1 commit into
dgolovin wants to merge 1 commit into
Conversation
Fix redhat-developer#773. Red Hat SSO authentication provider matches existing sessions with exactly the same scopes. Sandbox should use the same scopes as other Red Hat extensions to avoid triggering authentication dialog when there is already session created by Red Hat SSO Authentication provider triggered from different Red Hat extension. Signed-off-by: Denis Golovin <dgolovin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #773.
Red Hat SSO authentication provider matches existing sessions with exactly the same scopes. Sandbox should use the same scopes as Red Hat SSO extension to avoid triggering authentication dialog when there is already session created by Red Hat SSO Authentication provider triggered from different Red Hat extension.