RHIDP-3504: Update the doc on changing RHDH logo #1033
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagak
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1033/ @ 04/02/25 16:51:56 |
Update the doc on changing RHDH logo
jmagak
force-pushed
the
RHIDP-3504-Add-Documentation-for-Changing-Logo-in-Developer-Hub
branch
from
229004e to
5bc6b3c
Compare
linfraze
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
According to CCS guidelines, variables should be italicized. Otherwise this is good to go.
In the future, we might consider formatting this as a proper procedure module with numbered steps. If it is truly a concept, then we should format it as a proper concept module. Currently, it is a mix.
modules/customizing-the-appearance/proc-customize-rhdh-branding-logo.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-branding-logo.adoc
Outdated
Show resolved
Hide resolved
|
/cc @debsmita1 |
|
/cc @ciiay |
ciiay
suggested changes
Apr 2, 2025
modules/customizing-the-appearance/proc-customize-rhdh-branding-logo.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-branding-logo.adoc
Outdated
Show resolved
Hide resolved
modules/customizing-the-appearance/proc-customize-rhdh-branding-logo.adoc
Show resolved
Hide resolved
jmagak
force-pushed
the
RHIDP-3504-Add-Documentation-for-Changing-Logo-in-Developer-Hub
branch
from
8bca66b to
25a108d
Compare
jmagak
force-pushed
the
RHIDP-3504-Add-Documentation-for-Changing-Logo-in-Developer-Hub
branch
from
25a108d to
cb97e4a
Compare
|
New changes are detected. LGTM label has been removed. |
jmagak
added
Technical review done ⛅
linfraze
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.4, 1.5, 1.6, main
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-3504
Preview link: 9.2. Customizing the branding logo of your Developer Hub instance