Skip to content

RHIDP-12635: Flavours for Operator#2165

Merged
Gerry-Forde merged 3 commits into
redhat-developer:mainfrom
jmagak:RHIDP-12635-Flavours-for-Operator
May 25, 2026
Merged

RHIDP-12635: Flavours for Operator#2165
Gerry-Forde merged 3 commits into
redhat-developer:mainfrom
jmagak:RHIDP-12635-Flavours-for-Operator

Conversation

@jmagak

@jmagak jmagak commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@rhdh-bot

rhdh-bot commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Build Results

Build passed -- 34/34 titles | 77s
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-2165/

Content Quality Assessment

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features

Summary

Checks: 19 total, 19 pass, 0 fail

19 checks: 19 pass, 0 fail

Run node build/scripts/cqa/index.js --all --fix locally to review and auto-fix issues.

Updated 2026-05-25 08:12:13 UTC

@jmagak jmagak requested a review from gazarenkov May 5, 2026 18:00
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 1e64f41 to c7209c7 Compare May 6, 2026 11:10
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from c7209c7 to 7026d66 Compare May 6, 2026 12:29
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 7026d66 to 36e22e9 Compare May 7, 2026 09:44
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 2a4f27b to 5768588 Compare May 7, 2026 17:40
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 5768588 to 613f130 Compare May 7, 2026 18:00
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 613f130 to b014e02 Compare May 11, 2026 06:44
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from b014e02 to a98c6ca Compare May 11, 2026 12:37
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from a98c6ca to 9c6b785 Compare May 11, 2026 16:54
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 9c6b785 to 486dd96 Compare May 12, 2026 13:09
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 486dd96 to 17c85cb Compare May 13, 2026 11:01
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 5fd5934 to 32da3a4 Compare May 20, 2026 08:26
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 32da3a4 to 89fdd72 Compare May 20, 2026 12:36
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 89fdd72 to 09dbb0c Compare May 20, 2026 13:13
Jdubrick
Jdubrick reviewed May 20, 2026
View reviewed changes

@Jdubrick Jdubrick left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, mostly I think we should coordinate these changes with @pabel-rh because there is overlap. I wonder if it is best to direct to the dedicated section for configuring Lightspeed instead of having it mixed in with these docs?

Comment thread modules/configure_configuring-rhdh/proc-configure-ai-assistance-for-developer-productivity.adoc Outdated

[NOTE]
====
{ls-short} uses a bring-your-own-model (BYOM) architecture. You must provide your own LLM provider API endpoint and credentials.

@Jdubrick Jdubrick May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there should be, I know @pabel-rh has https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/2210/changes opened for other Lightspeed docs changes, and she covers the provider setup in those changes. @pabel-rh @jmagak I am inclined to leave it up to you two on how you want to handle this so we don't duplicate?

Comment thread modules/configure_configuring-rhdh/proc-configure-ai-assistance-for-developer-productivity.adoc Outdated
gabemontero
gabemontero reviewed May 20, 2026
View reviewed changes

@gabemontero gabemontero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my comments have either been addressed @jmagak or have been carried forward by @Jdubrick 's responses

I'll defer to him for the final approval for the lightspeed piece

thanks

@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from 09dbb0c to d1475a2 Compare May 21, 2026 07:08
@jmagak jmagak force-pushed the RHIDP-12635-Flavours-for-Operator branch from d1475a2 to e44e80b Compare May 21, 2026 07:08
@sonarqubecloud

sonarqubecloud Bot commented May 21, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pabel-rh pabel-rh self-requested a review May 21, 2026 07:31
@jmagak

jmagak commented May 21, 2026

Copy link
Copy Markdown
Member Author

I think my comments have either been addressed @jmagak or have been carried forward by @Jdubrick 's responses

@gabemontero, Thanks again for the review. I appreciate your detailed feedback.

@jmagak jmagak requested a review from Jdubrick May 21, 2026 14:23
Jdubrick
Jdubrick reviewed May 21, 2026
View reviewed changes

@Jdubrick Jdubrick left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but otherwise lgtm with the new redirection to the Lightspeed configuration docs. Thanks @jmagak @pabel-rh

Comment thread modules/configure_configuring-rhdh/ref-pre-configured-settings-for-common-use-cases.adoc Outdated
gazarenkov
gazarenkov approved these changes May 25, 2026
View reviewed changes
Comment thread modules/configure_configuring-rhdh/proc-deploy-rhdh-for-workflow-automation.adoc Outdated
@sonarqubecloud

sonarqubecloud Bot commented May 25, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Gerry-Forde

Gerry-Forde commented May 25, 2026

Copy link
Copy Markdown
Member

/cherry-pick release-1.10

@openshift-cherrypick-robot

openshift-cherrypick-robot commented May 25, 2026

Copy link
Copy Markdown
Contributor

@Gerry-Forde: new pull request created: #2235

Details

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pabel-rh pabel-rh Awaiting requested review from pabel-rh

4 more reviewers

@rm3l rm3l rm3l left review comments

@gabemontero gabemontero gabemontero left review comments

@Jdubrick Jdubrick Jdubrick left review comments

@gazarenkov gazarenkov gazarenkov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Peer review done 📘 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jmagak @rhdh-bot @rm3l @Gerry-Forde @openshift-cherrypick-robot @gazarenkov @gabemontero @Jdubrick @pabel-rh