Skip to content

RHIDP-12601: Scorecard supports custom key values and colors#2214

Merged
rh-tokeefe merged 11 commits into
redhat-developer:mainfrom
rh-tokeefe:RHIDP-12601
Jun 4, 2026
Merged

RHIDP-12601: Scorecard supports custom key values and colors#2214
rh-tokeefe merged 11 commits into
redhat-developer:mainfrom
rh-tokeefe:RHIDP-12601

Conversation

@rh-tokeefe

@rh-tokeefe rh-tokeefe commented May 18, 2026

Copy link
Copy Markdown
Member

@rhdh-bot

rhdh-bot commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR Build Results

Build passed -- 35/35 titles | 74s
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-2214/


Content Quality Assessment

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features

Summary

Checks: 19 total, 19 pass, 0 fail

19 checks: 19 pass, 0 fail

Run node build/scripts/cqa/index.js --all --fix locally to review and auto-fix issues.


Updated 2026-06-04 13:03:42 UTC

@dzemanov dzemanov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rh-tokeefe thank you for the updates, looks great! I have left some last comments and then we are good to go

@rh-tokeefe rh-tokeefe added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Jun 3, 2026

@dzemanov dzemanov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the changes!

@jmagak jmagak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor suggestions.

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@rh-tokeefe rh-tokeefe merged commit 1dfe1d0 into redhat-developer:main Jun 4, 2026
6 checks passed
@rh-tokeefe

Copy link
Copy Markdown
Member Author

/cherrypick release-1.10

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@rh-tokeefe: new pull request created: #2321

Details

In response to this:

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants