-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(about): fix the illogical statement that we only run on AKS or EKS... if it's OCP #835
base: main
Are you sure you want to change the base?
Conversation
…EKS... if it's OCP Signed-off-by: Nick Boldt <[email protected]>
/cherry-pick release-1.4 |
@nickboldt: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.3 |
@nickboldt: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jmagak Were you also working on this task? |
Thanks for making this important update. |
See also https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/833/files#diff-a0b73123541403cc024ce5b9a45f44f437770873e0ed18ad48b8bd99457157a0L9-R9 which seems like a less ideal change to make |
@Gerry-Forde , yes, I am working on updating the wording in the Supported Platforms section. Instead of a list, I have included a statement with a link to the RHDH Life cycle and supported platforms article. I have a PR already for the same, as @nickboldt has highlighted here. |
@nickboldt @christophe-f this is definitely an important update but please see the reasoning behind Judith's PR and my suggestion wrt some of the comments on that PR. |
What does this PR do?
chore(about): fix the illogical statement that we only run on AKS or EKS... if it's OCP
Signed-off-by: Nick Boldt [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.