Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHIDP-5725: Incorrect plugin name in the Customizing the Home page cards code snippet #883

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

pabel-rh
Copy link
Contributor

@pabel-rh pabel-rh commented Jan 28, 2025

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
1.4.x, main
Issue:
RHIDP-5725
Preview link: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-883/customizing/#customizing-the-home-page

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jan 28, 2025

@pabel-rh
Copy link
Contributor Author

@04kash, I've updated the right plugin names as per the upstream docs.
I did not find the following entities in the upstream docs but I've updated it anyway here. Do let me know if this is okay.

  • Headline
  • Markdown
  • Placeholder
  • Featured docs

Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hmanwani-rh
Copy link
Member

@pabel-rh Is this PR ready to merge?

@pabel-rh
Copy link
Contributor Author

Not yet, @hmanwani-rh . Kashish requested for @christoph-jerolimov to review the PR too. Just waiting for his lgtm.

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for that fix!

@themr0c themr0c merged commit e0d2c50 into redhat-developer:release-1.4 Jan 31, 2025
3 checks passed
@pabel-rh pabel-rh mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants