Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHIDP-5489 Enabling authentication with your authentication provider #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
RHIDP-5489 Enabling authentication with your authentication provider #891
Changes from 2 commits
ad2a49f
d3675ad
8a47329
ca8b0dd
5001ccf
62c40bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gashcrumb Does the
dynamic-plugins.yaml
file content need to be that long? I would assume that if the plugins has defined default values, it is sufficient to enable the plugin. Is it correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these LDAP plugins aren't a great example, most of the config here is concerned with getting these plugins to talk to LDAP. It's probably less important than the touch points where the user is required to integrate either configuration or code to connect authentication providers to the RHDH app. I have just finished up another example that I could walk you through if you like here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first sight this example is maybe even more complex, because we have 4 plugins.
Would an example plugin defining static users be sufficient for the demonstration purpose? Or is it a requirement to delegate authentication to an external service?