Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing parameter in auth set up #898

Open
wants to merge 4 commits into
base: release-1.4
Choose a base branch
from

Conversation

jmagak
Copy link
Contributor

@jmagak jmagak commented Jan 30, 2025

Adds the prompt: auto config which is not set in the current RHDH docs for RHBK auth provider set up here.

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s): 1.4

Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5681

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jan 30, 2025

Copy link
Member

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I have a few small comments.

It would also be nice to add a description here explaining this config:

Something like:
prompt: auto: To allow the identity provider to automatically determine whether to prompt for credentials or skip the login redirect if you have an active SSO session.

Some more useful information to consider including:

Without setting this value, the provider will default to prompt: none, which assumes that you are already logged on in the IDP and will reject the sign-in request without an active session.

prompt: login: will force the identity provider to always require credentials from the user.

Copy link
Member

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few more comments, thank you!

@jmagak jmagak force-pushed the RHIDP-5681-Missing--parameter-configuration-in-auth-set-up branch from 1f43691 to a1b8a0a Compare February 4, 2025 19:29
@jmagak jmagak force-pushed the RHIDP-5681-Missing--parameter-configuration-in-auth-set-up branch from a1b8a0a to 43c5c77 Compare February 4, 2025 19:36
@jmagak jmagak requested a review from JessicaJHee February 6, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants