-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing parameter in auth set up #898
base: release-1.4
Are you sure you want to change the base?
Added missing parameter in auth set up #898
Conversation
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-898/ @ 02/04/25 19:39:07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! I have a few small comments.
It would also be nice to add a description here explaining this config:
Something like:
prompt: auto
: To allow the identity provider to automatically determine whether to prompt for credentials or skip the login redirect if you have an active SSO session.
Some more useful information to consider including:
Without setting this value, the provider will default to prompt: none
, which assumes that you are already logged on in the IDP and will reject the sign-in request without an active session.
prompt: login
: will force the identity provider to always require credentials from the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few more comments, thank you!
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
modules/authentication/proc-enabling-authentication-with-rhbk.adoc
Outdated
Show resolved
Hide resolved
1f43691
to
a1b8a0a
Compare
a1b8a0a
to
43c5c77
Compare
Adds the
prompt: auto
config which is not set in the current RHDH docs for RHBK auth provider set up here.IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.4
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5681