RHIDP-5491 configure expiry on refresh token cookie #899
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrice Flore-Thébault <[email protected]>
linfraze
approved these changes
Feb 5, 2025
Comment on lines
+162
to
+175
| `sessionDuration`:: | ||
| Lifespan of the user session. | ||
| Enter a duration in `ms` library format (such as '24h', '2 days'), ISO duration, or "human duration" as used in code. | ||
| + | ||
| .`app-config-rhdh.yaml` fragment with optional `sessionDuration` field | ||
| [source,yaml,subs="+quotes"] | ||
| ---- | ||
| auth: | ||
| providers: | ||
| github: | ||
| production: | ||
| sessionDuration: { hours: 24 } | ||
| ---- | ||
|
|
There was a problem hiding this comment.
Just an example / future consideration for clear and consistent configuration examples across RHDH docs.
Suggested change
| `sessionDuration`:: | |
| Lifespan of the user session. | |
| Enter a duration in `ms` library format (such as '24h', '2 days'), ISO duration, or "human duration" as used in code. | |
| + | |
| .`app-config-rhdh.yaml` fragment with optional `sessionDuration` field | |
| [source,yaml,subs="+quotes"] | |
| ---- | |
| auth: | |
| providers: | |
| github: | |
| production: | |
| sessionDuration: { hours: 24 } | |
| ---- | |
| + | |
| . (Optional) In your`app-config-rhdh.yaml` file, configure the `sessionDuration` field. For example: | |
| + | |
| [source,yaml,subs="+quotes"] | |
| ---- | |
| auth: | |
| providers: | |
| github: | |
| production: | |
| sessionDuration: { <session-duration> } (1) | |
| ---- | |
| <1> Lifespan of the user session in `ms` library format (such as '24h', '2 days'), ISO duration, or "human duration" as used in code. |
There was a problem hiding this comment.
The user cannot copy and paste the proposed example. This would decrease usability for the user.
themr0c
added
do-not-merge/hold
and removed
Peer review needed 📖
SME review needed 🔩
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.6
Add the relevant labels to the Pull Request.
Issue: https://issues.redhat.com/browse/RHIDP-5491
Depends on: backstage/backstage#27821