feat: add dynamic plugins factory usability enhancements#46
Conversation
Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
…ability Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
Signed-off-by: Frank Kong <frkong@redhat.com>
Signed-off-by: Frank Kong <frkong@redhat.com>
Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
…hashes Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: March 25, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-81e0fe3Traceability
|
Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
…deps Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: March 25, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-e77b6e6Traceability
|
…ng native Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: March 26, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-d1e3ae3Traceability
|
Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: March 27, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-30aa937Traceability
|
Assisted-By: Cursor Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: March 27, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-ab84357Traceability
|
Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: March 27, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-3625ac9Traceability
|
They will only see whatever logs are outputted by the RHDH CLI, so it should capture the |
Ok I guess we can have it use the latest patch by default and they can change it if they want to. |
Does this require running the tool with debug logging? I only see this output for example: |
@gashcrumb rhdh-dynamic-plugin-factory/scripts/export-workspace.sh Lines 55 to 65 in 662a793 Example Error I generated using the aws-ecs example without the package.json patch
|
|
Nice! You might need to adjust the search a bit, this yarn output file was renamed slightly as of 1.10.1 here last week. |
@gashcrumb Ah ok, so it's now |
|
Hmm it seems using the latest cli (10.0.1) is crashing when doing frontend plugin compilation. I'll hold off on switching to INFO If you wish to change the defaults, add "scalprum" configuration to plugin "package.json" file, or use the
'--scalprum-config' option to specify an external config.
INFO /home/frkong/.npm/_npx/6f3461dc3b5b6b27/node_modules/@red-hat-developer-hub/cli/dist/lib/bundler/bundlePlugi
n.cjs.js:74
INFO throw new Error(errors2[0]);
INFO ^
INFO
INFO Error: The 'compilation' argument must be an instance of Compilation
INFO at
/home/frkong/.npm/_npx/6f3461dc3b5b6b27/node_modules/@red-hat-developer-hub/cli/dist/lib/bundler/bundlePlugi
n.cjs.js:74:19
INFO at
/home/frkong/.npm/_npx/6f3461dc3b5b6b27/node_modules/@red-hat-developer-hub/cli/node_modules/webpack/lib/web
pack.js:199:27
INFO at process.processTicksAndRejections (node:internal/process/task_queues:85:11)
INFO
INFO Node.js v22.16.0 Ok it seems when running with |
|
Okay, thanks for the fix for rhdh-cli, I've run the release job for 1.10.2 and it should be available now. |
Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: April 1, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-b43c1e5Traceability
|
|
Anything else we need on this, or do you think it's good to merge? |
|
@gashcrumb I'll probably add more e2e tests/examples in a separate PR. But ideally I would like @davidfestal and @kadel to take a look as well. |
Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: April 6, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-15cb185Traceability
|
kadel
left a comment
There was a problem hiding this comment.
Code review — found 3 issues to address.
Note: The config.py issue below couldn't be placed inline since the lines are unchanged in this PR.
src/rhdh_dynamic_plugin_factory/config.py lines 560-566
Bug: the second if should be elif. Currently, lines containing "Error" are logged twice (as error and as info), and lines with both "Error" and "npm warn" are never logged as warning.
# Current:
def conditional_stderr_log(line: str) -> None:
if "Error" in line:
self.logger.error(line)
if "npm warn" in line: # <-- should be elif
self.logger.warning(line)
else:
self.logger.info(line)# Fix:
def conditional_stderr_log(line: str) -> None:
if "Error" in line:
self.logger.error(line)
elif "npm warn" in line:
self.logger.warning(line)
else:
self.logger.info(line)Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: April 15, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-f99fe07Traceability
|
Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: April 21, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-bf72433Traceability
|
Signed-off-by: Frank Kong <frkong@redhat.com>
Container Image PublishedMulti-platform container images are now available.
Expires: April 22, 2026 Pull Commands# Multi-platform (auto-selects correct architecture)
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46
# Or with specific commit SHA
podman pull quay.io/rhdh-community/dynamic-plugins-factory:pr-46-a95c640Traceability
|
✅ E2E Tests PassedAll end-to-end integration tests passed for the container image. Image:
Traceability
|
Description
plugins-list.yamlauto-generation andplugins-list.yamlbuild argument auto-generationWhich issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer