chore(e2e): add Playwright annotations to all spec files#2394
Closed
zdrapela wants to merge 3 commits into
Closed
Conversation
5b6bec9 to
1d6b6ee
Compare
Add component and workspace annotations to every test.describe block using Playwright's declarative details parameter. Remove the old runtime annotation push from keycloak. Update CLAUDE.md to document the convention. Assisted-by: OpenCode
1d6b6ee to
5e86e39
Compare
Assisted-by: OpenCode
Add component and workspace annotations to every test.beforeAll block using test.info().annotations.push(). Update the existing annotation in keycloak to also include the workspace. Update CLAUDE.md to document the convention. Assisted-by: OpenCode
f13aae3 to
76037fd
Compare
|
Member
Author
|
@jrichter1 You were right - the check was failing, because there were indentation issues. I created this pre-commit hook to avoid similar issues in the future. #2397 |
Member
Author
|
Closing this PR as this is implemented in e2e test utils: redhat-developer/rhdh-e2e-test-utils#99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
componentandworkspaceannotations to everytest.beforeAllblock across all 27 E2E spec files (18 workspaces)catalog-users.spec.tsto also include workspaceCLAUDE.mdto document the annotation conventionJira: https://redhat.atlassian.net/browse/RHIDP-13047
Annotation types
component"plugins"workspacetech-radar,rbac)Approach chosen: runtime
test.info().annotations.push()inbeforeAll(Option B)Annotations are pushed at the start of each
test.beforeAll:Options evaluated
Option A: Declarative
test.describedetails parameterdetails.annotationparameter ontest.describetest.describecall signaturetest.describe(...)block when arguments are added, triggering pre-existing formatting issues across all files and failing CIOption B (chosen): Runtime
test.info().annotations.push()inbeforeAlltest.beforeAllOption C: Fixture-based injection in e2e-test-utils
rhdhfixture based on project/workspace nameWhy Option B
detailsparameter totest.describe(Option A) causes prettier to reformat the entire function call, surfacing pre-existing formatting issues across all files and failing CIChanges
test.info().annotations.push()as first statement intest.beforeAllworkspaceannotation