feat(dcm-backend): read dcm.apiUrl with legacy fallback#3603
Merged
asmasarw merged 2 commits intoJun 28, 2026
Conversation
gciavarrini
requested review from
a team,
asmasarw,
jkilzi and
mareklibra
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
force-pushed
the
FLPATH-4424-rename-dcm-api-url
branch
from
57ca9c7 to
da647f2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
=======================================
Coverage 54.21% 54.21%
=======================================
Files 2312 2312
Lines 88532 88533 +1
Branches 24661 24663 +2
=======================================
+ Hits 48000 48001 +1
- Misses 39040 39077 +37
+ Partials 1492 1455 -37
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This was referenced Jun 26, 2026
|
gabriel-farache
pushed a commit
to dcm-project/control-plane
that referenced
this pull request
Jun 29, 2026
Renames the `dcm-ui` environment variable from `DCM_API_GATEWAY_URL` to `DCM_API_URL` in compose and Helm deploy configs, matching the control-plane monolith naming. Part of [FLPATH-4424](https://redhat.atlassian.net/browse/FLPATH-4424) **Depends on:** [rhdh-plugins #3603](redhat-developer/rhdh-plugins#3603) (merged) Until then, deployments using the old env var still work via the plugin legacy fallback. **Follow-up:** quadlet-deploy rename in dcm-project/quadlet-deploy#7. Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com> Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
added a commit
to dcm-project/quadlet-deploy
that referenced
this pull request
Jun 30, 2026
Renames the `dcm-ui` quadlet env var from `DCM_API_GATEWAY_URL` to `DCM_API_URL`, matching the control-plane monolith naming from. The URL value is unchanged (`http://control-plane:8080`). Part of [FLPATH-4424](https://redhat.atlassian.net/browse/FLPATH-4424).⚠️ **Merge order (required):**⚠️ 1. [rhdh-plugins #3603](redhat-developer/rhdh-plugins#3603) + new `dcm-ui` image 2. [control-plane #17](dcm-project/control-plane#17) 3. this PR #### Why `verify_compose_alignment.yml` is unchanged Jira lists two quadlet files, but the verify playbook does not hardcode env var names. It clones upstream `control-plane/deploy/compose.yaml` and compares compose env keys to quadlet templates at runtime. Once control-plane `main` uses `DCM_API_URL`, the existing assert covers the new name with no alias or mapping. A verify edit is only needed when PRs land out of order; we merge in sequence, so no change here. -- Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the DCM backend API config from
dcm.apiGatewayUrl/DCM_API_GATEWAY_URLtodcm.apiUrl/DCM_API_URL, reflecting the control-plane monolith instead of the legacy API gateway.The backend proxy prefers
dcm.apiUrland falls back todcm.apiGatewayUrlso existing deployments keep working during migration.Production and dynamic app config bind both env vars until deploy configs switch to
DCM_API_URL.Follow-up PRs in
control-planeandquadlet-deploywill switch deploy configs after this merges and a newdcm-uiimage is published. No UI changes, config/backend only.Documented via config.d.ts and app-config samples; no README env docs today.
Fixes: FLPATH-4424
✔️ Checklist