mcp-integrations: Remove string arrays in zod object schemas #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Changed Packages
|
|
maysunfaisal
approved these changes
Oct 10, 2025
gabemontero
reviewed
Oct 13, 2025
There was a problem hiding this comment.
one clarification question only based on the debug you @johnmcollier and @maysunfaisal did last week that you noted in scrum status
definitely getting into the nitty gritty wrt all this ... cool deal
| tags: z // need to see how the MCP backend will handle this | ||
| .array(z.string()) | ||
| tags: z | ||
| .string() |
There was a problem hiding this comment.
any sense @johnmcollier @maysunfaisal if the use of arrays was a violation of the MCP spec or is this a work around for how llama stack implements MCP tool calling ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Some MCP clients have issues with how the backstage MCP server converts the zod objects to json schemas. As a temporary workaround, this PR just removes them altogether and switches to single string objects containing comma separated items.
Longer term, looking at the upstream plugin to see why this is happening would be preferred.
✔️ Checklist