[releae-1.9]fix(theme): active sidebar nav link styles using aria-current under BackstageSidebar drawer#2889
Merged
Conversation
…ackstageSidebar drawer
karthikjeeyar
requested review from
Eswaraiahsapram
and removed request for
a team
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
|
Review Summary by QodoStyle active sidebar nav links with aria-current attribute
WalkthroughsDescription• Add CSS styles for active sidebar navigation links using aria-current="page" attribute • Apply selected navigation colors to active links in BackstageSidebar drawer • Ensure active link typography inherits parent color styling • Add changeset documenting patch version update Diagramflowchart LR
A["BackstageSidebar drawer"] -->|"add aria-current selector"| B["a[aria-current=page] styles"]
B -->|"apply colors"| C["sidebarItemInteractionBackgroundColor"]
B -->|"apply colors"| D["navigationSelectedColor"]
C -->|"match"| E["Selected nav appearance"]
D -->|"match"| E
File Changes1. workspaces/theme/plugins/theme/src/utils/createComponents.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
✔️ Checklist