Skip to content

RHIDP-13413: Bootstrap basic AGENTS.md for RHDH AI workspaces#3230

Merged
johnmcollier merged 3 commits into
redhat-developer:mainfrom
johnmcollier:addrhdhaiagentsmd
Jun 26, 2026
Merged

RHIDP-13413: Bootstrap basic AGENTS.md for RHDH AI workspaces#3230
johnmcollier merged 3 commits into
redhat-developer:mainfrom
johnmcollier:addrhdhaiagentsmd

Conversation

@johnmcollier

Copy link
Copy Markdown
Member

Hey, I just made a Pull Request!

Adds AGENTS.md to the following rhdh-ai maintained workspaces:

  • lightspeed
  • ai-integrations
  • mcp-integrations

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Assisted-by: Claude Sonnet 4.6
Signed-off-by: John Collier <jcollier@redhat.com>
@rhdh-qodo-merge

rhdh-qodo-merge Bot commented May 21, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Remediation recommended

1. MCP env var typo 🐞 Bug ≡ Correctness
Description
workspaces/mcp-integrations/AGENTS.md contains a malformed setup instruction that mentions
MCP_TOKENS, but the workspace documentation/config consistently uses MCP_TOKEN. Following the
new instruction will leave MCP_TOKEN unset and can break MCP auth in the dev environment.
Code

workspaces/mcp-integrations/AGENTS.md[27]

Evidence
The newly added AGENTS.md line includes MCP_TOKENS, but the workspace README and dev app-config
explicitly instruct/use MCP_TOKEN, showing MCP_TOKENS is incorrect here.

workspaces/mcp-integrations/AGENTS.md[27-27]
workspaces/mcp-integrations/README.md[5-12]
workspaces/mcp-integrations/app-config.yaml[40-45]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`workspaces/mcp-integrations/AGENTS.md` has an incorrect/malformed bullet:
- It includes an empty parenthetical `()`
- It mentions a non-existent env var name (`MCP_TOKENS`) alongside `MCP_TOKEN`

This contradicts the workspace’s existing setup docs and config, which use `MCP_TOKEN`.

## Issue Context
The workspace README and app-config both reference `MCP_TOKEN` (not `MCP_TOKENS`) for static token auth.

## Fix Focus Areas
- workspaces/mcp-integrations/AGENTS.md[27-27]

Suggested replacement text (example):
- `When running the workspace dev environment, set the MCP_TOKEN environment variable to an 8+ character value.`

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@sonarqubecloud

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown

Review Summary by Qodo

Add AGENTS.md documentation for RHDH AI workspaces

📝 Documentation

Grey Divider

Walkthroughs

Description
• Add AGENTS.md documentation to three RHDH AI workspaces
• Document build commands, conventions, and architecture for each workspace
• Create CLAUDE.md reference files pointing to AGENTS.md
• Establish AI model collaboration guidelines with Assisted-by footer requirement
Diagram
flowchart LR
  A["Three Workspaces<br/>lightspeed<br/>ai-integrations<br/>mcp-integrations"] -->|"Add AGENTS.md"| B["Workspace Documentation<br/>Build commands<br/>Conventions<br/>Architecture"]
  A -->|"Add CLAUDE.md"| C["Reference Files<br/>@AGENTS.md"]

Loading

File Changes

1. workspaces/ai-integrations/AGENTS.md 📝 Documentation +26/-0

AI Integrations workspace documentation

• Documents AI Integration Plugins workspace with build and test commands
• Describes Backstage plugin structure and backend module conventions
• Explains shared library architecture and PR requirements with Assisted-by footer

workspaces/ai-integrations/AGENTS.md


2. workspaces/ai-integrations/CLAUDE.md 📝 Documentation +1/-0

Reference to AI Integrations AGENTS.md

• Creates reference file pointing to AGENTS.md

workspaces/ai-integrations/CLAUDE.md


3. workspaces/lightspeed/AGENTS.md 📝 Documentation +28/-0

Lightspeed plugin workspace documentation

• Documents Lightspeed Plugin workspace with build, test, and E2E commands
• Describes PatternFly UI components and dual frontend variants (modern and legacy)
• Explains Knex database access and migration structure
• Specifies PR conventions requiring Assisted-by footer

workspaces/lightspeed/AGENTS.md


View more (3)
4. workspaces/lightspeed/CLAUDE.md 📝 Documentation +1/-0

Reference to Lightspeed AGENTS.md

• Creates reference file pointing to AGENTS.md

workspaces/lightspeed/CLAUDE.md


5. workspaces/mcp-integrations/AGENTS.md 📝 Documentation +33/-0

MCP Integrations workspace documentation

• Documents MCP Plugins workspace with build and test commands
• Describes MCP tool organization, authentication inheritance, and description guidelines
• Provides porting instructions from upstream Backstage repository
• Specifies environment variable requirements and PR conventions with upstream linking

workspaces/mcp-integrations/AGENTS.md


6. workspaces/mcp-integrations/CLAUDE.md 📝 Documentation +1/-0

Reference to MCP Integrations AGENTS.md

• Creates reference file pointing to AGENTS.md

workspaces/mcp-integrations/CLAUDE.md


Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added the documentation Improvements or additions to documentation label May 21, 2026
@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.09%. Comparing base (4866641) to head (1c38b2f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3230   +/-   ##
=======================================
  Coverage   53.09%   53.09%           
=======================================
  Files        2306     2306           
  Lines       88276    88276           
  Branches    24567    24583   +16     
=======================================
  Hits        46873    46873           
  Misses      41051    41051           
  Partials      352      352           
Flag Coverage Δ *Carryforward flag
adoption-insights 83.70% <ø> (ø) Carriedforward from 4866641
ai-integrations 67.95% <ø> (ø)
app-defaults 69.79% <ø> (ø) Carriedforward from 4866641
augment 46.39% <ø> (ø) Carriedforward from 4866641
boost 74.96% <ø> (ø) Carriedforward from 4866641
bulk-import 72.46% <ø> (ø) Carriedforward from 4866641
cost-management 14.10% <ø> (ø) Carriedforward from 4866641
dcm 61.79% <ø> (ø) Carriedforward from 4866641
extensions 61.53% <ø> (ø) Carriedforward from 4866641
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 4866641
global-header 59.71% <ø> (ø) Carriedforward from 4866641
homepage 49.92% <ø> (ø) Carriedforward from 4866641
install-dynamic-plugins 56.77% <ø> (ø) Carriedforward from 4866641
konflux 91.49% <ø> (ø) Carriedforward from 4866641
lightspeed 68.54% <ø> (ø)
mcp-integrations 85.46% <ø> (ø)
orchestrator 38.30% <ø> (ø) Carriedforward from 4866641
quickstart 63.76% <ø> (ø) Carriedforward from 4866641
sandbox 79.56% <ø> (ø) Carriedforward from 4866641
scorecard 83.96% <ø> (ø) Carriedforward from 4866641
theme 61.26% <ø> (ø) Carriedforward from 4866641
translations 7.25% <ø> (ø) Carriedforward from 4866641
x2a 57.25% <ø> (ø) Carriedforward from 4866641

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4866641...1c38b2f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jdubrick Jdubrick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnmcollier what do you think about adding the required Node version to the files? I've had a few instances where the agent tries to run yarn commands and ends up on Node 18 and they fail and it "lists as a pre-existing issue"

@gabemontero gabemontero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just commented once but in theory could apply to all 3 agents.md

Comment thread workspaces/ai-integrations/AGENTS.md
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added stale and removed stale labels Jun 9, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added stale and removed stale labels Jun 24, 2026
@gabemontero

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

you still pursuing this PR @johnmcollier ?

there are a couple of review comments I haven't seen a response to yet ?

@johnmcollier

johnmcollier commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

Okay @gabemontero coming back to this.

I think it's still worthwhile to merge this, however I suspect rhdh-plugins will need its own strategy for agent readiness, given how it's organized as a monorepo. For now, let's just merge the AGENTS.md for each workspace we own.

Signed-off-by: John Collier <jcollier@redhat.com>
@johnmcollier

Copy link
Copy Markdown
Member Author

@gabemontero Oops, PR finally updated, forgot to push yesterday.

@johnmcollier johnmcollier merged commit b9f42ce into redhat-developer:main Jun 26, 2026
30 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants