chore(scorecard): migrate from Material UI v4 to MUI v5 #3312
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@red-hat-developer-hub/backstage-plugin-scorecard': patch | ||
| --- | ||
|
|
||
| Replace Material UI v4 imports with MUI v5 and scope JSS class names to prevent style collisions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Copyright Red Hat, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| const materialUiMigrationEslintConfig = { | ||
| restrictedImports: [ | ||
| { | ||
| name: '@material-ui/core', | ||
| message: 'Use @mui/material instead of Material UI v4.', | ||
| }, | ||
| { | ||
| name: '@material-ui/lab', | ||
| message: 'Use @mui/material instead of Material UI v4.', | ||
| }, | ||
| { | ||
| name: '@material-ui/styles', | ||
| message: | ||
| 'Use @mui/styles, @mui/material (sx/styled), or Backstage UI instead of Material UI v4.', | ||
| }, | ||
| ], | ||
| restrictedImportPatterns: ['@material-ui/*'], | ||
| }; | ||
|
|
||
| /** | ||
| * Shared ESLint config for frontend packages in the scorecard workspace. | ||
| */ | ||
| module.exports = packageDir => | ||
|
Check warning on line 39 in workspaces/scorecard/eslint.frontend-shared.cjs
|
||
| require('@backstage/cli/config/eslint-factory')( | ||
| packageDir, | ||
| materialUiMigrationEslintConfig, | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,18 @@ | ||
| /* | ||
| * Copyright Red Hat, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| // eslint-disable-next-line @backstage/no-relative-monorepo-imports -- workspace ESLint shared config | ||
| module.exports = require('../../eslint.frontend-shared.cjs')(__dirname); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[low] missing-peer-dependency
The PR removes @material-ui/icons but the updated backstage-plugin-theme v0.14.7 still declares @material-ui/icons: ^4.11.3 as a peerDependency, which may produce warnings.