Skip to content

FLPATH-4262 | [DCM] Provider health status is static with no refresh or polling#3342

Merged
asmasarw merged 2 commits into
redhat-developer:mainfrom
asmasarw:feature/provider-refresh
Jun 10, 2026
Merged

FLPATH-4262 | [DCM] Provider health status is static with no refresh or polling#3342
asmasarw merged 2 commits into
redhat-developer:mainfrom
asmasarw:feature/provider-refresh

Conversation

@asmasarw

@asmasarw asmasarw commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Tasks:

FLPATH-4262 | [DCM] Provider health status is static with no refresh or polling


Changes:

Add a manual refresh button to the Providers table to update health status without a full page reload.

A sync icon button now appears next to the search field in the Providers card header. Clicking it re-fetches the provider list (including health_status) while keeping the table visible. A spinner is shown on the button during the request. The initial page load behaviour is unchanged.

@asmasarw asmasarw requested review from a team, jkilzi and mareklibra as code owners June 9, 2026 14:28
@rhdh-gh-app

rhdh-gh-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-dcm workspaces/dcm/plugins/dcm patch v1.0.0

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.00%. Comparing base (9fb8693) to head (2c1c175).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3342      +/-   ##
==========================================
- Coverage   54.01%   54.00%   -0.02%     
==========================================
  Files        2403     2404       +1     
  Lines       87411    87627     +216     
  Branches    24182    24273      +91     
==========================================
+ Hits        47219    47323     +104     
- Misses      38709    38787      +78     
- Partials     1483     1517      +34     
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from 378bfd0
ai-integrations 70.03% <ø> (ø) Carriedforward from 378bfd0
app-defaults 69.60% <ø> (ø) Carriedforward from 378bfd0
augment 46.39% <ø> (ø) Carriedforward from 378bfd0
bulk-import 72.86% <ø> (ø) Carriedforward from 378bfd0
cost-management 17.48% <ø> (ø) Carriedforward from 378bfd0
dcm 59.65% <94.11%> (-1.58%) ⬇️
extensions 62.24% <ø> (ø) Carriedforward from 378bfd0
global-floating-action-button 74.30% <ø> (ø) Carriedforward from 378bfd0
global-header 61.63% <ø> (ø) Carriedforward from 378bfd0
homepage 51.52% <ø> (ø) Carriedforward from 378bfd0
install-dynamic-plugins 56.23% <ø> (ø) Carriedforward from 378bfd0
konflux 91.01% <ø> (ø) Carriedforward from 378bfd0
lightspeed 68.52% <ø> (ø) Carriedforward from 378bfd0
mcp-integrations 85.46% <ø> (ø) Carriedforward from 378bfd0
orchestrator 37.33% <ø> (ø) Carriedforward from 378bfd0
quickstart 62.09% <ø> (ø) Carriedforward from 378bfd0
sandbox 79.49% <ø> (ø) Carriedforward from 378bfd0
scorecard 83.86% <ø> (ø) Carriedforward from 378bfd0
theme 64.54% <ø> (ø) Carriedforward from 378bfd0
translations 8.49% <ø> (ø) Carriedforward from 378bfd0
x2a 78.79% <ø> (ø) Carriedforward from 378bfd0

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb8693...2c1c175. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkilzi jkilzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@jkilzi jkilzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a failed refresh, Retry shows the empty state instead of a spinner because hasLoadedRef stays true while items is empty. Consider using loading when items.length === 0, or preserving items on refresh failure. Also worth a unit test asserting refreshing === true during manual reload.

Comment thread workspaces/dcm/plugins/dcm/src/hooks/useCrudTab.ts
@asmasarw asmasarw requested a review from jkilzi June 10, 2026 07:46
@sonarqubecloud

Copy link
Copy Markdown

@asmasarw asmasarw merged commit 23ab1ea into redhat-developer:main Jun 10, 2026
76 checks passed
@asmasarw asmasarw deleted the feature/provider-refresh branch June 10, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants