Skip to content

boost(#3335): add initial test infrastructure with boost-common package#3358

Closed
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3335-boost-test-infrastructure
Closed

boost(#3335): add initial test infrastructure with boost-common package#3358
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/3335-boost-test-infrastructure

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Create the boost-common plugin package with a minimal test to enable yarn test in the boost workspace. Follows the same pattern used by scorecard-common and other workspaces in this monorepo.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com


Closes #3335

Post-script verification

  • Branch is not main/master (agent/3335-boost-test-infrastructure)
  • Secret scan passed (gitleaks — 4da4d17bde9a26b337bc99d8e289405c4cb4d233..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Create the boost-common plugin package with a minimal test to enable
`yarn test` in the boost workspace. Follows the same pattern used by
scorecard-common and other workspaces in this monorepo.

Closes #3335

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fullsend-ai-coder fullsend-ai-coder Bot requested review from a team, durandom and gabemontero as code owners June 10, 2026 17:36
@rhdh-gh-app

rhdh-gh-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @red-hat-developer-hub/backstage-plugin-boost-common

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-boost-common workspaces/boost/plugins/boost-common none v0.1.0

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 10, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:37 PM UTC · Completed 5:48 PM UTC
Commit: 4da4d17 · View workflow run →

@sonarqubecloud

Copy link
Copy Markdown

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Low

  • [package.json field completeness] workspaces/boost/plugins/boost-common/package.json — The package.json is missing homepage and bugs fields. However, only 6 of 13 existing common packages include these fields, while 7 omit them — this is not a strong convention.
    Remediation: Optionally add "homepage": "https://red.ht/rhdh" and "bugs": "https://github.com/redhat-developer/rhdh-plugins/issues".

  • [architectural coherence] workspaces/boost/plugins/boost-common/package.json — The @backstage/cli devDependency is pinned to ^0.34.5, while the majority of common packages use ^0.36.0 or higher. Two other packages (augment-common, x2a-common) share the same version, so this is not unprecedented, but aligning with the majority is recommended for a brand-new package.
    Remediation: Consider updating to ^0.36.0 or higher to match other workspaces.

Info

  • [package.json structure] workspaces/boost/plugins/boost-common/package.json — The pluginPackages array only lists the common package itself. Most established common packages list all sibling packages. Acceptable for an initial PR; update when sibling packages are added.

  • [test file organization] workspaces/boost/plugins/boost-common/src/index.test.ts — No other -common package in the monorepo has an index.test.ts file. This is a positive deviation; keeping the test is fine.

  • [scope alignment] workspaces/boost/.eslintrc.js — The workspace-level .eslintrc.js omits the copyright header that lightspeed's includes. However, scorecard and orchestrator also omit it, so both conventions exist in the repo.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 10, 2026
@durandom

Copy link
Copy Markdown
Member

Closing — image rebuild in progress with yarn@4.12.0 pin and corepack permission fix. Will retrigger after new image lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost: set up initial test infrastructure

1 participant