Skip to content

feat(bulk-import): replace MUI v4 imports and makeStyles with MUI v5 sx prop#3361

Merged
debsmita1 merged 1 commit into
redhat-developer:mainfrom
its-mitesh-kumar:feat/bulk-import-mui-v5-migration
Jun 11, 2026
Merged

feat(bulk-import): replace MUI v4 imports and makeStyles with MUI v5 sx prop#3361
debsmita1 merged 1 commit into
redhat-developer:mainfrom
its-mitesh-kumar:feat/bulk-import-mui-v5-migration

Conversation

@its-mitesh-kumar

@its-mitesh-kumar its-mitesh-kumar commented Jun 10, 2026

Copy link
Copy Markdown
Member

Description

Replace all Material UI v4 (@material-ui/core) references and deprecated makeStyles from @mui/styles in the bulk-import workspace with MUI v5 sx prop. Uses tss-react/mui for generating scoped class names where external Backstage components require string class names. Adopts theme logos from @red-hat-developer-hub/backstage-plugin-theme and adds an ESLint shared config to guard against future v4 imports.

Fixed

UI after changes

Scaffolder Flow

S_.2026-06-11.at.1.19.09.AM.mov

Gitlab

S_.2026-06-11.at.1.12.55.AM.mov

GitHub

S_.2026-06-11.at.12.46.31.AM.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Made with Cursor

…sx prop

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rhdh-gh-app

rhdh-gh-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
app-legacy workspaces/bulk-import/packages/app-legacy none v0.0.3
app workspaces/bulk-import/packages/app none v0.0.1
@red-hat-developer-hub/backstage-plugin-bulk-import workspaces/bulk-import/plugins/bulk-import patch v7.3.5

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.99%. Comparing base (985b994) to head (b2bb85d).
⚠️ Report is 21 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
- Coverage   54.00%   53.99%   -0.02%     
==========================================
  Files        2404     2402       -2     
  Lines       87604    87571      -33     
  Branches    24252    24253       +1     
==========================================
- Hits        47307    47280      -27     
+ Misses      38712    38706       -6     
  Partials     1585     1585              
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from 985b994
ai-integrations 70.03% <ø> (ø) Carriedforward from 985b994
app-defaults 69.60% <ø> (ø) Carriedforward from 985b994
augment 46.39% <ø> (ø) Carriedforward from 985b994
bulk-import 72.80% <100.00%> (-0.06%) ⬇️
cost-management 17.48% <ø> (ø) Carriedforward from 985b994
dcm 59.65% <ø> (ø) Carriedforward from 985b994
extensions 62.25% <ø> (ø) Carriedforward from 985b994
global-floating-action-button 74.30% <ø> (ø) Carriedforward from 985b994
global-header 61.63% <ø> (ø) Carriedforward from 985b994
homepage 51.52% <ø> (ø) Carriedforward from 985b994
install-dynamic-plugins 56.23% <ø> (ø) Carriedforward from 985b994
konflux 91.01% <ø> (ø) Carriedforward from 985b994
lightspeed 68.49% <ø> (ø) Carriedforward from 985b994
mcp-integrations 85.46% <ø> (ø) Carriedforward from 985b994
orchestrator 37.33% <ø> (ø) Carriedforward from 985b994
quickstart 62.09% <ø> (ø) Carriedforward from 985b994
sandbox 79.56% <ø> (ø) Carriedforward from 985b994
scorecard 83.86% <ø> (ø) Carriedforward from 985b994
theme 64.54% <ø> (ø) Carriedforward from 985b994
translations 8.49% <ø> (ø) Carriedforward from 985b994
x2a 78.79% <ø> (ø) Carriedforward from 985b994

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985b994...b2bb85d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@debsmita1 debsmita1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this on RHDH locally

Image

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 11, 2026
@debsmita1 debsmita1 merged commit a85170e into redhat-developer:main Jun 11, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants