-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(marketplace): add marketplace-cli and generate command #348
feat(marketplace): add marketplace-cli and generate command #348
Conversation
bea5e1b
to
0441d92
Compare
Changed Packages
|
45dd0c4
to
fb266c6
Compare
sonar cube is complaining about duplication because the marketplace-cli is based on the rhdh-cli in this repo |
Not sure what is going on with the test. The failure seems unrelated to changes in this PR and I see the same error on the |
it generates Package entities based on the RHDH's dynamic-plugins.default.yaml
fb266c6
to
102fc45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @kadel !
Thanks for that. I reviewed the code and it lgtm.
Can you just please revert the changes in the root of rhdh-plugins and double-check your dependencies.
After that feel free to add a changeset so that we can ship it. :)
workspaces/marketplace/packages/cli/src/commands/generate/index.ts
Outdated
Show resolved
Hide resolved
…x.ts Co-authored-by: Christoph Jerolimov <[email protected]>
Co-authored-by: Christoph Jerolimov <[email protected]>
Co-authored-by: Christoph Jerolimov <[email protected]>
1f760d1
to
0e0b8ea
Compare
``` | ||
Usage: marketplace-cli [options] [command] | ||
|
||
Options: | ||
-h, --help | ||
|
||
Commands: | ||
generate [options] | ||
help [command] | ||
``` | ||
|
||
### `marketplace-cli generate` | ||
|
||
``` | ||
Usage: marketplace-cli generate [options] | ||
|
||
Options: | ||
-p, --default-dynamic-plugins-config [path] | ||
-o, --output-dir [path] | ||
--namespace [namespace] | ||
--owner [owner] | ||
-h, --help | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How awesome is this cli report 🤯 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and it works well already. We can merge it when you want. I added two small comments below anyway. ;)
workspaces/marketplace/packages/cli/src/commands/generate/index.ts
Outdated
Show resolved
Hide resolved
|
3c12103
into
redhat-developer:main
Hey, I just made a Pull Request!
Related to https://issues.redhat.com/browse/RHIDP-5290
This adds new
marketplace-cli
and implementsgenerate
command.This command generates Plugin entities based on the information from the dynamic-plugins.default.yaml and wrapper's
package.json
. It assumes that allpackages
in the config files are wrappers.example: