feat(e2e): orchestrator e2e tests#3562
Conversation
sanketpathak
requested review from
a team,
christoph-jerolimov,
karthikjeeyar,
lholmquist and
lokanandaprabhu
as code owners
Changed Packages
|
|
This pull request adds a new top-level directory under |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3562 +/- ##
==========================================
+ Coverage 54.02% 54.18% +0.16%
==========================================
Files 2327 2331 +4
Lines 89215 89354 +139
Branches 25009 25046 +37
==========================================
+ Hits 48194 48418 +224
+ Misses 39567 39482 -85
Partials 1454 1454
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
sanketpathak
force-pushed
the
e2e-orchestrator-tests
branch
from
8e66186 to
a3280d8
Compare
|
This pr rhdhorchestrator/backstage-orchestrator-workflows#17 needs to be merged, to have sample-retry-test and test-ui-props tests working |
|
/retest |
sanketpathak
force-pushed
the
e2e-orchestrator-tests
branch
from
a3280d8 to
c7de015
Compare
| if (!config.has('orchestrator.workflowLogProvider.loki')) { | ||
| logger.info( | ||
| 'Loki workflow log provider is not configured, skipping module initialization', | ||
| ); | ||
| return; | ||
| } |
There was a problem hiding this comment.
i think i agree with @jrichter1 here. My thought here is that if the user needs to manually add this plugin, then they should also be responsible for adding this config and should see a proper error if they didn't add any config
There was a problem hiding this comment.
@lholmquist So, for the tests to work, should I add orchestrator.workflowLogProvider.lokivalue in app-config to avoid the error, or do you suggest a different way, like having a different app-config-e2e for the test run
There was a problem hiding this comment.
you could just add the loki stuff to the app-config to avoid the error. it can just be some dummy values. you will need baseUrl and token https://github.com/redhat-developer/rhdh-plugin-export-overlays/blob/main/workspaces/orchestrator/metadata/rhdh-bsp-orchestrator-backend-mod-loki.yaml#L35
|
3 participants
Hey, I just made a Pull Request!
Playwright e2e tests to test the orchestrator workspace dev page https://redhat.atlassian.net/browse/RHIDP-14653
✔️ Checklist