ci: add reusable workflow to build dynamic plugins container images#3636
Open
christoph-jerolimov wants to merge 1 commit into
Open
ci: add reusable workflow to build dynamic plugins container images#3636christoph-jerolimov wants to merge 1 commit into
christoph-jerolimov wants to merge 1 commit into
Conversation
Code Review by QodoSorry, something went wrongWe weren't able to complete the code review on our side. Please try again |
Introduce build-container-image.yml that uses rhdh-cli to package and push workspace images to quay.io. Wire it into CI (per-PR images with 2w expiry) and into the release workflow (next + latest tags). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
force-pushed
the
ci/build-container-images
branch
from
eafbe12 to
158888e
Compare
|
kadel
reviewed
Jun 30, 2026
| - name: Push image to registry | ||
| env: | ||
| REGISTRY: ${{ inputs.registry }} | ||
| QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }} |
Member
There was a problem hiding this comment.
I think that this will not work.
This workflow is triggered from ci.yaml which is triggered by on: pull_request, this means that secrets won't be injected into this workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Introduce build-container-image.yml that uses rhdh-cli to package and push workspace images to quay.io.
Wire it into CI for a per-PR build, and the release workflow for next and latest tags.
The per-PR images has a 2w expiry, next and images a 4w expiry.
The images are build per workspace, not separated per package. The workspace is also added as a prefix to the tag, so that we don't need a quay repo per workspace. Feedback is very welcome for this. Both is different to the overlay build process but simplifies this, because rhdh-cli just builds all packages.
✔️ Checklist