Skip to content

Fix skill spec compliance and add automation scripts#12

Merged
schultzp2020 merged 6 commits into
redhat-developer:mainfrom
schultzp2020:fix/skill-review-fixes
May 5, 2026
Merged

Fix skill spec compliance and add automation scripts#12
schultzp2020 merged 6 commits into
redhat-developer:mainfrom
schultzp2020:fix/skill-review-fixes

Conversation

@schultzp2020

Copy link
Copy Markdown
Collaborator

Summary

Reviewed all 7 RHDH skills against the Agent Skills open standard and fixed all flagged issues.

Metadata & Reference Fixes

  • Fix all frontmatter name fields to lowercase-hyphens (spec requirement)
  • Rewrite descriptions to third person per spec
  • Fix broken reference paths across overlay workflows
  • Normalize CLI naming (rhdh-plugin$RHDH) in 5 workflow files
  • Add missing reference_index entries in rhdh skill (versions.md, slack-notification.md)
  • Fix stale hardcoded :1.9 version tags in env-reference.md
  • Add missing gotchas to create-frontend-plugin (Scalprum name mismatch) and generate-frontend-wiring (file extensions, unscoped packages, new frontend system)

New Automation Scripts (stdlib-only Python, per ADR-0002)

Skill Script Purpose
rhdh-local fetch-plugin-metadata.py Replaces fragile 3-step curl chain for fetching plugin metadata
create-backend-plugin scaffold.py Automates Backstage app creation + backend plugin scaffolding
create-frontend-plugin scaffold.py Automates frontend plugin scaffolding with optional theme support
overlay analyze-pr.py Consolidates ~8 sequential gh API calls into single-pass PR analysis
overlay triage-prs.py Automates PR classification, staleness checking, and report generation
export-and-package export-plugin.py Full export → package → push pipeline

All scripts: #!/usr/bin/env python3, argparse with --help, --json output, proper exit codes, cross-platform.

Bug Fixes

  • Fix Windows path separator inconsistency in sync.py (.as_posix() for glob-discovered paths)
  • Skip Unix permission check (S_IXUSR) on Windows in test suite

Testing

  • All 245 tests passing (0 failures)
  • All 6 new scripts compile cleanly (py_compile)

Review all 7 RHDH skills against the Agent Skills open standard and fix
all flagged issues.

Metadata and reference fixes:
- Fix all frontmatter name fields to lowercase-hyphens
- Rewrite descriptions to third person per spec
- Fix broken reference paths across overlay workflows
- Normalize CLI naming in workflow files
- Add missing reference_index entries in rhdh skill
- Fix stale hardcoded version tags in env-reference.md
- Add missing gotchas to create-frontend-plugin and generate-frontend-wiring

New automation scripts (stdlib-only Python per ADR-0002):
- rhdh-local: fetch-plugin-metadata.py
- create-backend-plugin: scaffold.py
- create-frontend-plugin: scaffold.py
- overlay: analyze-pr.py, triage-prs.py
- export-and-package: export-plugin.py

Bug fixes:
- Fix Windows path separator inconsistency in sync.py
- Skip Unix permission check on Windows in test suite
- Remove unused os import from create-frontend-plugin scaffold.py
- Fix import sort order (I001) in analyze-pr.py and triage-prs.py
- Rename ambiguous variable l -> lbl (E741) in analyze-pr.py and triage-prs.py
- create-backend-plugin: 'Steps 2-3' -> Step 2, renumber 4-6 to 3-5
- enable-plugin workflow: 'Steps 1-3' -> Step 1, renumber 4-8 to 2-6
- create-frontend-plugin: clean up 'Steps 2 + 4' reference in notes
- Fix UnicodeEncodeError on Windows for emoji output in analyze-pr.py
  and triage-prs.py (reconfigure stdout to UTF-8)
- Fix unhandled OSError/PermissionError crash in both scaffold scripts
  when given an invalid path (now prints clean error, exits 1)
@schultzp2020 schultzp2020 merged commit 5457f0e into redhat-developer:main May 5, 2026
3 checks passed
@schultzp2020 schultzp2020 deleted the fix/skill-review-fixes branch May 5, 2026 21:31
durandom pushed a commit to durandom/rhdh-skill that referenced this pull request May 8, 2026
rhdh-jira skill:
- Add REST API fallback for custom field updates (Story Points, Size, Team,
  Release Note Type) when acli silently fails
- Add GraphQL query patterns for complex reads (issueSearchStable with JQL,
  single-issue with all custom fields, pagination)
- Add auth.md as single-sourced token/credential reference (no transitive
  loading between REST and GraphQL references)
- Add OpenAPI spec discovery and GraphQL introspection for dynamic schema
  discovery
- Add .jira-token capability gate with setup.py validation (format, permissions)
- Add Getting Started guide link for acli setup
- Add 4 new gotchas (redhat-developer#9-redhat-developer#12): custom field failures, sprint JSON wrapping,
  GraphQL beta header, token format
- Update setup.py: token file check, permission warnings, multi-line detection

skill-maker:
- Add references/api-skill-patterns.md: credential handling, API schema
  discovery, live validation, instance-specific values
- Add Reference Architecture section to spec-guide.md: agent-only audience,
  transitive loading anti-pattern, error placement, decision tables
- Update Phase 1 interview: new question about external services/APIs
- Update Phase 5 checklist: reference architecture and API skill checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant