fix: skill audit fixes — broken refs, descriptions, fallbacks#27
Merged
Conversation
- Fix critical: rhdh-test-plan-review auth ref ~/.claude/... → ../rhdh-jira/ - Add cross-skill fallback notes (create-plugin, overlay, rhdh-local, rhdh-pr-review) - Expand descriptions with trigger phrases (overlay, rhdh, rhdh-local, create-plugin) - Add command-metadata.json to create-plugin as single source of truth - Clarify gcloud_token.py is a library module, not a CLI script
Both are router skills with multiple commands, routing tables, and reference indexes — exactly the pattern where XML tags help agents parse sections unambiguously. create-plugin: add <essential_principles>, <intake>, <routing>, <reference_index> rhdh-jira: add <essential_principles>, <intake>, <routing>, <reference_index>
Add the explicit wait instruction back to the skill-maker intake so the router pauses for user input instead of auto-routing immediately. Add a focused regression test to keep the intake pause behavior covered. Co-authored-by: Cursor <cursoragent@cursor.com>
schultzp2020
force-pushed
the
fix/skill-audit-fixes
branch
from
177dccb to
99c1790
Compare
Collaborator
Author
|
I audited all our skills against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create-pluginandrhdh-jirato explicit XML router sections so intake, routing, and reference boundaries are clearer for agents; aligncreate-plugincommand metadata with that structureoverlay,rhdh,rhdh-local,rhdh-pr-review, andrhdh-test-plan-reviewby adding standalone fallbacks, correcting broken cross-skill references, expanding trigger phrases, and clarifyinggcloud_token.pyusageskill-maker's own<intake>block to explicitly wait for user input before routing, and add a focused regression test so that pause instruction stays coveredTest plan
uv run pytest