Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adding CI.md documentation #1802

Closed
wants to merge 47 commits into from
Closed

docs: adding CI.md documentation #1802

wants to merge 47 commits into from

Conversation

nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Oct 22, 2024 •
edited by openshift-ci bot
Loading

Description

Added CI documentation

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1802!

@nilgaar nilgaar marked this pull request as ready for review October 22, 2024 11:44
@nilgaar nilgaar requested a review from a team as a code owner October 22, 2024 11:44
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1802!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1802!

@nilgaar nilgaar changed the title adding CI.md documentation [e2e] adding CI.md documentation Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1802!

psrna
psrna reviewed Oct 23, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

christoph-jerolimov
christoph-jerolimov approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It had lgtm already above.

/lgtm
/approve

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 19, 2024

/test images

@openshift-ci openshift-ci bot removed the lgtm label Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@subhashkhileri
Copy link
Member

/test e2e-tests

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@psrna
Copy link

psrna commented Nov 20, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, psrna, zdrapela

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [christoph-jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nilgaar
Copy link
Contributor Author

nilgaar commented Nov 20, 2024

TBH this PR is broken or something and it never merges. I have to open it again.

@nilgaar nilgaar closed this Nov 20, 2024
@nilgaar nilgaar mentioned this pull request Nov 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psrna psrna psrna left review comments

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@zdrapela zdrapela zdrapela approved these changes

@gustavolira gustavolira Awaiting requested review from gustavolira

@subhashkhileri subhashkhileri Awaiting requested review from subhashkhileri

@josephca josephca Awaiting requested review from josephca

@albarbaro albarbaro Awaiting requested review from albarbaro

Assignees

@christoph-jerolimov christoph-jerolimov

@psrna psrna

@zdrapela zdrapela

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nilgaar @zdrapela @subhashkhileri @psrna @christoph-jerolimov @josephca @openshift-merge-robot