refactor(homepage): migrate from internal dynamic-home-page to rhdh plugin#1944
Conversation
|
Skipping CI for Draft Pull Request. |
|
The image is available at: |
christoph-jerolimov
force-pushed
the
use-rhdh-plugin-dynamic-home-page
branch
4 times, most recently
from
c2b1cd0 to
adca658
Compare
|
The image is available at: |
christoph-jerolimov
force-pushed
the
use-rhdh-plugin-dynamic-home-page
branch
from
adca658 to
73cceb3
Compare
christoph-jerolimov
force-pushed
the
use-rhdh-plugin-dynamic-home-page
branch
from
73cceb3 to
4f818fa
Compare
christoph-jerolimov
changed the title
|
/cc @ciiay |
christoph-jerolimov
force-pushed
the
use-rhdh-plugin-dynamic-home-page
branch
from
4f818fa to
c6e316b
Compare
|
The image is available at: |
|
/retest |
ciiay
left a comment
ciiay
left a comment
There was a problem hiding this comment.
/lgtm
I didn't try all the homepage setting variations, but I did verify that the dynamic-home-page plugin works from the new rhdh-plugins package using the PR image on a OCP v4.15 cluster.
|
/retest |
|
/test e2e-tests |
|
/retest |
|
The image is available at: |
|
/test e2e-tests |
|
/retest |
1 similar comment
|
/retest |
christoph-jerolimov
force-pushed
the
use-rhdh-plugin-dynamic-home-page
branch
from
6dd6cfe to
7e9d91a
Compare
|
|
The image is available at: |
|
/retest |
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
christoph-jerolimov
force-pushed
the
use-rhdh-plugin-dynamic-home-page
branch
from
7e9d91a to
93c055a
Compare
|
The image is available at: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciiay, gashcrumb, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merging this now because home page has currently no e2e tests and we want get this in so that the configuration is aligned with other plugins! Ticket to create e2e tests for homepage: RHIDP-5061 /override prow/e2e-tests |
|
@christoph-jerolimov: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…lugin (redhat-developer#1944) * refactor(homepage): remove internal dynamic-home-page plugin Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> * refactor(homepage): add wrapper for rhdh plugin Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com> --------- Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
6 participants
Description
Use moved plugin from https://github.com/redhat-developer/rhdh-plugins/tree/main/workspaces/homepage/plugins/dynamic-home-page
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer