Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update analytics-provider-segment wrapper #1945

Conversation

04kash
Copy link
Member

@04kash 04kash commented Nov 18, 2024

Description

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Nov 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@04kash 04kash force-pushed the create-analytics-provier-segment-wrapper branch from cd59215 to 6f56fe9 Compare November 18, 2024 14:15
Copy link
Contributor

@04kash 04kash marked this pull request as ready for review November 18, 2024 15:06
@04kash 04kash requested a review from a team as a code owner November 18, 2024 15:06
@04kash 04kash assigned schultzp2020 and unassigned schultzp2020 Nov 18, 2024
@04kash 04kash requested a review from schultzp2020 November 18, 2024 15:08
@04kash
Copy link
Member Author

04kash commented Nov 18, 2024

Will rebase again after #1908 is merged

Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
@04kash 04kash force-pushed the create-analytics-provier-segment-wrapper branch from 18f28aa to 4a79985 Compare November 18, 2024 16:34
Copy link
Contributor

Copy link
Contributor

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BethGriggs, christoph-jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [christoph-jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt merged commit 56f6845 into redhat-developer:main Nov 19, 2024
14 of 15 checks passed
teknaS47 pushed a commit to teknaS47/backstage-showcase that referenced this pull request Nov 28, 2024
* chore: update analytics-provider-segment wrapper

Signed-off-by: Kashish Mittal <[email protected]>

* run build:dockerfile

Signed-off-by: Kashish Mittal <[email protected]>

* fix wrapper tests errors

Signed-off-by: Kashish Mittal <[email protected]>

---------

Signed-off-by: Kashish Mittal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants