-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update analytics-provider-segment wrapper #1945
chore: update analytics-provider-segment wrapper #1945
Conversation
Skipping CI for Draft Pull Request. |
cd59215
to
6f56fe9
Compare
The image is available at: |
Will rebase again after #1908 is merged |
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
18f28aa
to
4a79985
Compare
|
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BethGriggs, christoph-jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* chore: update analytics-provider-segment wrapper Signed-off-by: Kashish Mittal <[email protected]> * run build:dockerfile Signed-off-by: Kashish Mittal <[email protected]> * fix wrapper tests errors Signed-off-by: Kashish Mittal <[email protected]> --------- Signed-off-by: Kashish Mittal <[email protected]>
Description
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer