Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rbac): fix edit rbac operations for high availability #2100

Merged
merged 5 commits into from
Jan 27, 2025
Merged

fix(rbac): fix edit rbac operations for high availability #2100

merged 5 commits into from
Jan 27, 2025

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Dec 12, 2024 •
edited
Loading

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@AndrienkoAleksandr AndrienkoAleksandr force-pushed the fix-edit-rbac-operations-for-high-availability branch from 50aa7ae to 30e0e81 Compare January 14, 2025 13:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@AndrienkoAleksandr AndrienkoAleksandr force-pushed the fix-edit-rbac-operations-for-high-availability branch from 30e0e81 to 1d2a613 Compare January 14, 2025 15:16
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@AndrienkoAleksandr AndrienkoAleksandr marked this pull request as ready for review January 20, 2025 13:35
@AndrienkoAleksandr AndrienkoAleksandr requested review from PatAKnight and dzemanov and removed request for dzemanov and its-mitesh-kumar January 20, 2025 13:36
PatAKnight
PatAKnight approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

lgtm

@PatAKnight
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PatAKnight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AndrienkoAleksandr
fix(rbac): update rbac-backend
56c1209 
Signed-off-by: Oleksandr Andriienko <[email protected]>
@AndrienkoAleksandr
use newer rbac-backend
a5215db 
Signed-off-by: Oleksandr Andriienko <[email protected]>
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the fix-edit-rbac-operations-for-high-availability branch from 6565ca6 to a5215db Compare January 27, 2025 16:43
@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@nickboldt nickboldt added the lgtm label Jan 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ee9d407 into redhat-developer:main Jan 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatAKnight PatAKnight PatAKnight approved these changes

@dzemanov dzemanov Awaiting requested review from dzemanov

Assignees

@PatAKnight PatAKnight

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrienkoAleksandr @PatAKnight @nickboldt @openshift-merge-robot