Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): fix ci tests #2164

Closed
wants to merge 9 commits into from
Closed

Conversation

nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Jan 9, 2025

Description

fix 2 ci tests

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from psrna and zdrapela January 9, 2025 10:04
Copy link
Contributor

github-actions bot commented Jan 9, 2025

@christoph-jerolimov
Copy link
Member

/retest

@zdrapela
Copy link
Member

/test all

1 similar comment
@nilgaar
Copy link
Contributor Author

nilgaar commented Jan 17, 2025

/test all

Copy link

openshift-ci bot commented Jan 17, 2025

@nilgaar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@albarbaro
Copy link
Contributor

/ok-to-test

Copy link

openshift-ci bot commented Jan 17, 2025

@albarbaro: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nilgaar
Copy link
Contributor Author

nilgaar commented Jan 17, 2025

/test all

1 similar comment
@nilgaar
Copy link
Contributor Author

nilgaar commented Jan 20, 2025

/test all

Copy link

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nilgaar. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nilgaar
Copy link
Contributor Author

nilgaar commented Jan 20, 2025

/test all

1 similar comment
@nilgaar
Copy link
Contributor Author

nilgaar commented Jan 20, 2025

/test all

@nilgaar
Copy link
Contributor Author

nilgaar commented Jan 21, 2025

/test all

Copy link
Contributor

Copy link

openshift-ci bot commented Jan 21, 2025

@nilgaar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests c9b0246 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nilgaar nilgaar closed this Jan 21, 2025
@nilgaar nilgaar deleted the RHIDP-5463 branch January 21, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants