Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): fix typo in folder name in CI build condition check #2184

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

gustavolira
Copy link
Contributor

Corrected the folder name from 'e2e' to 'e2e-tests' in workflow logic to ensure accurate conditional checks. This prevents incorrect build skips or triggers due to the inconsistent naming.

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Corrected the folder name from 'e2e' to 'e2e-tests' in workflow logic to ensure accurate conditional checks. This prevents incorrect build skips or triggers due to the inconsistent naming.

Signed-off-by: Gustavo Lira <[email protected]>
@openshift-ci openshift-ci bot requested review from dzemanov and rm3l January 14, 2025 18:13
Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit 1023e92 into redhat-developer:main Jan 14, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants