Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(fab): add new mountpoints to support provider #2199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

debsmita1
Copy link
Member

##Description:##
https://issues.redhat.com/browse/RHIDP-5478

##How to test changes / Special notes to the reviewer##

  • In your local rhdh-plugins repo, pull the changes from [WIP] feat(fab): created dynamic fab to be integrated in the RHDH app rhdh-plugins#293

  • In /workspaces/global-floating-action-button/plugins/global-floating-action-button/ directory, run

       npx --yes @janus-idp/cli package export-dynamic-plugin --dynamic-plugins-root path/to/rhdh/dynamic-plugins-root --dev
    
  • manually copy the bulk-import wrapper under the wrappers directory in rhdh and paste it into dynamic-plugins-root

  • In your local rhdh repo, add the following snippet in your app-config.yaml file

dynamicPlugins:
  rootDirectory: dynamic-plugins-root
  frontend:
    red-hat-developer-hub.backstage-plugin-bulk-import:
      mountPoints:
        - mountPoint: global.floatingactionbutton/component
          config:
            slot: 'page-end'
            icon: bulkImportIcon
            label: 'Bulk import'
            toolTip: 'Register multiple repositories in bulk'
            to: /bulk-import/repositories
      appIcons:
        - name: bulkImportIcon
          importName: BulkImportIcon
      dynamicRoutes:
        - path: /bulk-import/repositories
          importName: BulkImportPage
          menuItem:
            icon: bulkImportIcon
            text: Bulk import
    red-hat-developer-hub.backstage-plugin-global-floating-action-button:
      mountPoints:
        - mountPoint: application/context
          importName: DynamicGlobalFloatingActionButton
        - mountPoint: global.floatingactionbutton/component
          config:
            icon: github
            label: 'Git'
            toolTip: 'Github'
            to: https://github.com/debsmita1
  • In your local rhdh repo, run yarn install followed by yarn dev

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from debsmita1. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@debsmita1 debsmita1 requested review from ciiay and removed request for dzemanov and its-mitesh-kumar January 16, 2025 19:15
Copy link

openshift-ci bot commented Jan 16, 2025

@debsmita1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 497eb35 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant