-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor authProviderModule and dangerouslyAllowSignInWithoutUserInCatalog
config
#2354
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dangerouslyAllowSignInWithoutUserInCatalog
config
The image is available at: |
42907c8
to
77e816b
Compare
The image is available at: |
77e816b
to
8211499
Compare
The image is available at: |
8211499
to
034fe49
Compare
The image is available at: |
034fe49
to
16a584f
Compare
16a584f
to
2bcbd72
Compare
The image is available at: |
2bcbd72
to
0f3c330
Compare
The image is available at: |
auth e2e tests are broken due to UI changes - will be fixed in this PR |
0f3c330
to
b0142f6
Compare
The image is available at: |
b0142f6
to
b507c90
Compare
Signed-off-by: Jessica He <[email protected]>
Signed-off-by: Jessica He <[email protected]>
Signed-off-by: Jessica He <[email protected]>
b507c90
to
8d43e8d
Compare
The image is available at: |
/retest |
@JessicaJHee: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
dangerouslyAllowSignInWithoutUserInCatalog
configdangerouslyAllowSignInWithoutUserInCatalog
is now a resolver level config and applies to each resolver declarativelyExample usage:
See upstream changes included in the patches here
The new error message with this is:
"Login failed; caused by Error: Failed to sign-in, unable to resolve user identity. Please verify that your catalog contains the expected User entities that would match your configured sign-in resolver. For non-production environments, manually provision the user or disable the user provisioning requirement by setting the
dangerouslyAllowSignInWithoutUserInCatalog
option."Notes/Changes on TP auth providers:
auth0
resolver in RHDH resolves byfullProfile.id
gcp-iap
resolver in RHDH resolves byiapToken.email.split('@')[0]
onelogin
resolver in RHDH resolves byfullProfile.id
fullProfile.username
SAML
doesn’t have it’s own auth provider moduleWhich issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
Manual testing has been done for GitHub and Microsoft resolvers