-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(marketplace): allow plugins to extend the plugins page #2358
base: main
Are you sure you want to change the base?
feat(marketplace): allow plugins to extend the plugins page #2358
Conversation
Signed-off-by: Christoph Jerolimov <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
@christoph-jerolimov I checked out this PR and enabled the marketplace dynamic plugins. Plugins page seems to work fine but marketplace doesnt seem to load properly. I was just trying to test even with the marketplace plugins in place the Plugins page works fine or not. Am I missing something? Screen.Recording.2025-02-12.at.2.17.55.PM.mov |
text: Plugins | ||
icon: pluginsInfoIcon | ||
mountPoints: | ||
- mountPoint: internal.plugins/tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I think this works for me as a sufficiently specific way of mapping where these components need to go now and in the future. Maybe we can just kind of avoid advertising these internal mount points too much 😄
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
Description
This change will allow the marketplace plugin to extend the existing Admin > Plugins page with a new
internal.plugins/tab
.This is an interim solution until we remove the current installed plugins page (in 1.6, 1.7, ...)
The expectation is that the page looks similar to before when no other
internal.plugins/tab
mount point is specified!Local:
With an additional
internal.plugins/tab
it can look like this:Via an extra marketplace tab config:
Notice that this YAML depends on the latest change in this WIP PR redhat-developer/rhdh-plugins#401
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer