Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marketplace): allow plugins to extend the plugins page #2358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Feb 11, 2025

Description

This change will allow the marketplace plugin to extend the existing Admin > Plugins page with a new internal.plugins/tab.

This is an interim solution until we remove the current installed plugins page (in 1.6, 1.7, ...)

The expectation is that the page looks similar to before when no other internal.plugins/tab mount point is specified!

Local:

image

With an additional internal.plugins/tab it can look like this:

image

Via an extra marketplace tab config:

    red-hat-developer-hub.backstage-plugin-marketplace:
      appIcons:
        - name: marketplace
          importName: MarketplaceIcon
      dynamicRoutes:
        - path: /plugins/marketplace
          importName: InternalPluginInfoTab
      mountPoints:
        - mountPoint: internal.plugins/tab
          importName: InternalPluginInfoTabContent
          config:
            path: marketplace
            title: Marketplace

Notice that this YAML depends on the latest change in this WIP PR redhat-developer/rhdh-plugins#401

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

  1. It's mostly important that the plugins page works as before!
  2. If you like you can clone rhdh-plugins, checkout PR and install the marketplace into your local rhdh.

Copy link

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from christoph-jerolimov. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christoph-jerolimov christoph-jerolimov changed the title feat(plugins-page/marketplace): allow plugins to extend the plugins page feat(marketplace): allow plugins to extend the plugins page Feb 11, 2025
Copy link
Contributor

@divyanshiGupta
Copy link
Member

divyanshiGupta commented Feb 12, 2025

@christoph-jerolimov I checked out this PR and enabled the marketplace dynamic plugins. Plugins page seems to work fine but marketplace doesnt seem to load properly. I was just trying to test even with the marketplace plugins in place the Plugins page works fine or not. Am I missing something?

Screen.Recording.2025-02-12.at.2.17.55.PM.mov

text: Plugins
icon: pluginsInfoIcon
mountPoints:
- mountPoint: internal.plugins/tab
Copy link
Member

@gashcrumb gashcrumb Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think this works for me as a sufficiently specific way of mapping where these components need to go now and in the future. Maybe we can just kind of avoid advertising these internal mount points too much 😄

Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants