Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): update RBAC plugin version, add E2E tests to Showcase/RHDH #2374

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

teknaS47
Copy link
Contributor

Description

E2E tests for updated RBAC UI

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Feb 13, 2025

Hi @teknaS47. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@subhashkhileri
Copy link
Member

/ok-to-test

@teknaS47
Copy link
Contributor Author

/test e2e-tests

1 similar comment
@teknaS47
Copy link
Contributor Author

/test e2e-tests

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@teknaS47 teknaS47 changed the title [WIP] Update RBAC plugin version, add E2E tests to Showcase/RHDH chore(e2e): Update RBAC plugin version, add E2E tests to Showcase/RHDH Feb 20, 2025
@teknaS47 teknaS47 changed the title chore(e2e): Update RBAC plugin version, add E2E tests to Showcase/RHDH chore(e2e): update RBAC plugin version, add E2E tests to Showcase/RHDH Feb 20, 2025
Copy link
Contributor

Copy link
Contributor

@teknaS47
Copy link
Contributor Author

/test e2e-tests

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@subhashkhileri
Copy link
Member

/approve

Copy link
Member

@divyanshiGupta divyanshiGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests looks good

/lgtm

Copy link

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [divyanshiGupta,subhashkhileri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divyanshiGupta
Copy link
Member

Since this PR updates the version of the plugin as well I also tested plugin in cluster and it works as expected.

Screen.Recording.2025-02-25.at.2.58.02.PM.mov

@divyanshiGupta
Copy link
Member

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@divyanshiGupta: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@divyanshiGupta
Copy link
Member

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@divyanshiGupta: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants