-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): update RBAC plugin version, add E2E tests to Showcase/RHDH #2374
base: main
Are you sure you want to change the base?
Conversation
Hi @teknaS47. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The image is available at: |
/ok-to-test |
/test e2e-tests |
1 similar comment
/test e2e-tests |
The image is available at: |
The image is available at: |
The image is available at: |
The image is available at: |
The image is available at: |
The image is available at: |
The image is available at: |
The image is available at: |
The image is available at: |
The image is available at: |
/test e2e-tests |
The image is available at: |
dynamic-plugins/wrappers/backstage-community-plugin-rbac/package.json
Outdated
Show resolved
Hide resolved
The image is available at: |
The image is available at: |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests looks good
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, subhashkhileri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since this PR updates the version of the plugin as well I also tested plugin in cluster and it works as expected. Screen.Recording.2025-02-25.at.2.58.02.PM.mov |
/cherry-pick release-1.5 |
@divyanshiGupta: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.5 |
@divyanshiGupta: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
E2E tests for updated RBAC UI
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer