Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deprecation): mark roadiehq argocd frontend plugin deprecated in 1.5 (RHIDP-2028) #2375

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Feb 13, 2025

What does this PR do?

chore(deprecation): mark roadiehq argocd frontend plugin deprecated in 1.5 (RHIDP-2028)

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt nickboldt changed the title chore(deprecation): mark roadiehq argocd... chore(deprecation): mark roadiehq argocd frontend plugin deprecated in 1.5 (RHIDP-2028) Feb 13, 2025
Copy link
Contributor

@subhashkhileri
Copy link
Member

/test e2e-tests

@CryptoRodeo
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Feb 14, 2025

@CryptoRodeo: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label Feb 25, 2025
@nickboldt nickboldt force-pushed the roadie-argo-deprecated_1.5 branch from c64364c to e382bd7 Compare March 5, 2025 16:26
@nickboldt nickboldt removed the Stale label Mar 5, 2025
Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Copy link

openshift-ci bot commented Mar 5, 2025

@nickboldt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 4a1415d link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nickboldt
Copy link
Member Author

e2e tests are not relevant for this change, so the failure is misleading.

Copy link
Collaborator

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CryptoRodeo, schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 5, 2025
@nickboldt nickboldt merged commit ded617b into release-1.5 Mar 5, 2025
12 of 14 checks passed
@nickboldt nickboldt deleted the roadie-argo-deprecated_1.5 branch March 5, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants