-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update plugins with new k8s-client, update plugin annotator #2406
base: main
Are you sure you want to change the base?
Conversation
Update: - @backstage-community/plugin-acr - @backstage-community/plugin-jfrog-artifactory - @backstage-community/plugin-nexus-repository-manager - @backstage-community/plugin-quay - @backstage-community/plugin-rbac - @backstage-community/plugin-redhat-argocd - @backstage-community/plugin-scaffolder-backend-module-kubernetes - @backstage-community/plugin-tekton - @backstage-community/plugin-topology - @backstage-community/plugin-scaffolder-backend-module-annotator Signed-off-by: Oleksandr Andriienko <[email protected]>
The image is available at: |
@AndrienkoAleksandr RBAC e2e is failing as RBAC plugin has quite a lot of new features/enhancements and for that we are trying to update the version along with updated/new e2e tests with this PR - #2374. For now you can skip updating RBAC plugin version in this PR as it will be updated by the above PR. Or if you have any other suggestion please LMK. |
Signed-off-by: Oleksandr Andriienko <[email protected]>
The image is available at: |
Signed-off-by: Oleksandr Andriienko <[email protected]>
@04kash @CryptoRodeo @karthikjeeyar @debsmita1 @ciiay please give lgtm to the PR if you guys see no issues in updating RHDH with your plugins latest version. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The image is available at: |
dynamic-plugins/wrappers/backstage-community-plugin-topology/package.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
1 similar comment
/retest |
Signed-off-by: Oleksandr Andriienko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrienkoAleksandr I see that you have only updated the dependencies and not the plugin version for example here
"version": "1.10.0", |
The image is available at: |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
The image is available at: |
/retest |
1 similar comment
/retest |
@AndrienkoAleksandr: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Update:
Description
Update plugins with newer @kubernetes/client-node or @kubernetes/client-node. Use newer @backstage-community/plugin-scaffolder-backend-module-annotator updated to backstage 1.35
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer