Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update plugins with new k8s-client, update plugin annotator #2406

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AndrienkoAleksandr
Copy link
Contributor

Update:

  • @backstage-community/plugin-acr
  • @backstage-community/plugin-jfrog-artifactory
  • @backstage-community/plugin-nexus-repository-manager
  • @backstage-community/plugin-quay
  • @backstage-community/plugin-rbac
  • @backstage-community/plugin-redhat-argocd
  • @backstage-community/plugin-scaffolder-backend-module-kubernetes
  • @backstage-community/plugin-tekton
  • @backstage-community/plugin-topology
  • @backstage-community/plugin-scaffolder-backend-module-annotator

Description

Update plugins with newer @kubernetes/client-node or @kubernetes/client-node. Use newer @backstage-community/plugin-scaffolder-backend-module-annotator updated to backstage 1.35

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Update:
- @backstage-community/plugin-acr
- @backstage-community/plugin-jfrog-artifactory
- @backstage-community/plugin-nexus-repository-manager
- @backstage-community/plugin-quay
- @backstage-community/plugin-rbac
- @backstage-community/plugin-redhat-argocd
- @backstage-community/plugin-scaffolder-backend-module-kubernetes
- @backstage-community/plugin-tekton
- @backstage-community/plugin-topology
- @backstage-community/plugin-scaffolder-backend-module-annotator

Signed-off-by: Oleksandr Andriienko <[email protected]>
Copy link
Contributor

@divyanshiGupta
Copy link
Contributor

divyanshiGupta commented Feb 18, 2025

@AndrienkoAleksandr RBAC e2e is failing as RBAC plugin has quite a lot of new features/enhancements and for that we are trying to update the version along with updated/new e2e tests with this PR - #2374. For now you can skip updating RBAC plugin version in this PR as it will be updated by the above PR. Or if you have any other suggestion please LMK.

cc: @christoph-jerolimov @invincibleJai

Signed-off-by: Oleksandr Andriienko <[email protected]>
Copy link
Contributor

@divyanshiGupta
Copy link
Contributor

divyanshiGupta commented Feb 19, 2025

@04kash @CryptoRodeo @karthikjeeyar @debsmita1 @ciiay please give lgtm to the PR if you guys see no issues in updating RHDH with your plugins latest version. Thanks!

Copy link
Contributor

@divyanshiGupta divyanshiGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Copy link
Contributor

@CryptoRodeo CryptoRodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divyanshiGupta
Copy link
Contributor

/retest

1 similar comment
@divyanshiGupta
Copy link
Contributor

/retest

Signed-off-by: Oleksandr Andriienko <[email protected]>
Copy link
Contributor

@divyanshiGupta divyanshiGupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrienkoAleksandr I see that you have only updated the dependencies and not the plugin version for example here

it should be 1.11.0

@openshift-ci openshift-ci bot removed the approved label Feb 24, 2025
Copy link
Contributor

@PatAKnight
Copy link
Member

/retest

Copy link

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign coreydaley for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Copy link
Contributor

@AndrienkoAleksandr
Copy link
Contributor Author

/retest

1 similar comment
@divyanshiGupta
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Feb 25, 2025

@AndrienkoAleksandr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests ebf4d2e link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants