Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace a dead link with a valid one #2410

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

ciiay
Copy link
Member

@ciiay ciiay commented Feb 18, 2025

Description

Fix a dead link in doc.

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@christoph-jerolimov
Copy link
Member

/unassign

@christoph-jerolimov
Copy link
Member

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@christoph-jerolimov: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christoph-jerolimov
Copy link
Member

/jira refresh

@christoph-jerolimov
Copy link
Member

/retest

@christoph-jerolimov
Copy link
Member

/ok-to-test

@christoph-jerolimov
Copy link
Member

/override "Build Image"

Copy link

openshift-ci bot commented Feb 18, 2025

@christoph-jerolimov: Overrode contexts on behalf of christoph-jerolimov: Build Image

In response to this:

/override "Build Image"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christoph-jerolimov
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [christoph-jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christoph-jerolimov
Copy link
Member

/jira refresh
/retest

@kadel
Copy link
Member

kadel commented Feb 19, 2025

/override Build Image
only docs changes, image build is not triggered and not needed for this

Copy link

openshift-ci bot commented Feb 19, 2025

@kadel: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Build
  • Image

Only the following failed contexts/checkruns were expected:

  • Build Image
  • Build with Node.js 20
  • Test with Node.js 20
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override Build Image
only docs changes, image build is not triggered and not needed for this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kadel
Copy link
Member

kadel commented Feb 19, 2025

/override "Build Image"

Copy link

openshift-ci bot commented Feb 19, 2025

@kadel: Overrode contexts on behalf of kadel: Build Image

In response to this:

/override "Build Image"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 23e5e48 into redhat-developer:main Feb 19, 2025
10 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@christoph-jerolimov: new pull request created: #2415

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants