Skip to content

chore(e2e): add e2e tests for global header #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ciiay
Copy link
Member

@ciiay ciiay commented Feb 18, 2025

Description

Update e2e tests for global header.

Changes including:

  1. enabled global-header plugin in "showcase-rabc" and "showcase" test values
  2. added support field to the default configMap app-config-rhdh.yaml
  3. enabled notifications plugins to as it's a default component in global header
  4. added appConfig field to upstream.backstage config in order to test notification unread amount badge
  5. replaced openSidebar("Settings") with a new uiHelper function goToSettingsPage()`
  6. added default-global-header.spec.ts
  7. updated clickLink() and verifyLink() in uiHelper
  8. replaced openSidebar("Create...") with updated clickLink({ ariaLabel: "Create..." })
  9. updated getByPlaceholder("Search") to getByPlaceholder("Search", { exact: true }) so that it only specify the filter search element from main content

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@ciiay
Copy link
Member Author

ciiay commented Feb 19, 2025

/test e2e-tests

@ciiay ciiay force-pushed the rhidp-5474-e2e-test-for-global-header branch from 741341b to b49056d Compare February 19, 2025 16:17
@ciiay ciiay changed the title [WIP]fix(global-header): add e2e tests for global header fix(global-header): add e2e tests for global header Feb 19, 2025
@ciiay ciiay changed the title fix(global-header): add e2e tests for global header chore(e2e): add e2e tests for global header Feb 19, 2025
@ciiay ciiay force-pushed the rhidp-5474-e2e-test-for-global-header branch from 845f5a7 to 99f4cbf Compare February 19, 2025 23:36
@ciiay ciiay force-pushed the rhidp-5474-e2e-test-for-global-header branch from 6f6fd76 to 8dfbd1b Compare February 20, 2025 13:41
@ciiay
Copy link
Member Author

ciiay commented Feb 20, 2025

/test e2e-tests

@subhashkhileri
Copy link
Member

/approve

@ciiay ciiay requested a review from teknaS47 February 26, 2025 14:40
@teknaS47
Copy link
Contributor

Verified tests on a cluster. Looks good to me! /lgtm

@teknaS47
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhashkhileri, teknaS47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@teknaS47
Copy link
Contributor

/test e2e-tests

1 similar comment
@ciiay
Copy link
Member Author

ciiay commented Feb 27, 2025

/test e2e-tests

@openshift-merge-bot openshift-merge-bot bot merged commit 24bb5bd into redhat-developer:main Feb 27, 2025
15 checks passed
@ciiay
Copy link
Member Author

ciiay commented Feb 27, 2025

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@ciiay: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@invincibleJai
Copy link
Member

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@invincibleJai
Copy link
Member

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: #2412 failed to apply on top of branch "release-1.5":

Applying: fix(global-header): add e2e tests for global header
Using index info to reconstruct a base tree...
M	e2e-tests/playwright/e2e/authProviders/basic-authentication.spec.ts
M	e2e-tests/playwright/e2e/authProviders/github-provider.spec.ts
M	e2e-tests/playwright/e2e/authProviders/microsoft-provider.spec.ts
M	e2e-tests/playwright/e2e/authProviders/rhsso-76-provider.spec.ts
M	e2e-tests/playwright/utils/ui-helper.ts
Falling back to patching base and 3-way merge...
Auto-merging e2e-tests/playwright/utils/ui-helper.ts
Auto-merging e2e-tests/playwright/e2e/authProviders/rhsso-76-provider.spec.ts
Auto-merging e2e-tests/playwright/e2e/authProviders/microsoft-provider.spec.ts
Auto-merging e2e-tests/playwright/e2e/authProviders/github-provider.spec.ts
Auto-merging e2e-tests/playwright/e2e/authProviders/basic-authentication.spec.ts
CONFLICT (content): Merge conflict in e2e-tests/playwright/e2e/authProviders/basic-authentication.spec.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix(global-header): add e2e tests for global header

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@invincibleJai
Copy link
Member

Mannual cherry pick PR for this #2472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants