-
Notifications
You must be signed in to change notification settings - Fork 193
chore(e2e): add e2e tests for global header #2412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): add e2e tests for global header #2412
Conversation
/test e2e-tests |
741341b
to
b49056d
Compare
845f5a7
to
99f4cbf
Compare
6f6fd76
to
8dfbd1b
Compare
/test e2e-tests |
e2e-tests/playwright/e2e/authProviders/rhsso-76-provider.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
1381eea
to
9a93c6b
Compare
/approve |
Verified tests on a cluster. Looks good to me! /lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhashkhileri, teknaS47 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-tests |
1 similar comment
/test e2e-tests |
24bb5bd
into
redhat-developer:main
/cherry-pick release-1.5 |
@ciiay: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.5 |
@invincibleJai: only redhat-developer org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.5 |
@invincibleJai: #2412 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Mannual cherry pick PR for this #2472 |
Description
Update e2e tests for global header.
Changes including:
support
field to the default configMapapp-config-rhdh.yaml
appConfig
field toupstream.backstage
config in order to test notification unread amount badgeopenSidebar("Settings") with a new uiHelper function
goToSettingsPage()`default-global-header.spec.ts
clickLink()
andverifyLink()
inuiHelper
openSidebar("Create...")
with updatedclickLink({ ariaLabel: "Create..." })
getByPlaceholder("Search")
togetByPlaceholder("Search", { exact: true })
so that it only specify the filter search element from main contentWhich issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer