[release-1.5] feat(global-header): update header plugin and enable it by default #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciiay
changed the title
ciiay
changed the title
|
The image is available at: |
christoph-jerolimov
changed the title
christoph-jerolimov
force-pushed
the
cherry-pick-global-header
branch
from
268bb21 to
a135162
Compare
|
The image is available at: |
christoph-jerolimov
requested changes
Feb 19, 2025
ciiay
force-pushed
the
cherry-pick-global-header
branch
from
1a5cebd to
3d7dd28
Compare
|
The image is available at: |
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
ciiay
force-pushed
the
cherry-pick-global-header
branch
from
1d962dd to
9aac41d
Compare
|
The image is available at: |
|
/test e2e-tests |
christoph-jerolimov
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Thanks @ciiay!
Works well, I've tested the pr-2413-9aac41d7 image.
- Default header (enabled) looks good
- Disabled header worked
- Search works fine
- Notification button is shown when notification and signal plugin was enabled
- Support button is shown with app.support.url (and app.support.links)
I've tested also multiple pages and plugins (catalog, rbac, topology, settings) if the updated app scroll CSS rules works fine.
I can also confirm that the double scrollbar issue in techdocs is resolved.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christoph-jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
christoph-jerolimov
merged commit 5957df7
into
redhat-developer:release-1.5
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry picked all commits of global header.
Please make sure that the following steps are complete: