Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator version based on branch #2419

Conversation

zdrapela
Copy link
Member

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from dzemanov and psrna February 19, 2025 14:37
Copy link

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nickboldt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

github-actions bot commented Feb 19, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Operator version based on branch". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - chore
 - docs
 - style
 - refactor
 - perf
 - test
 - revert

nickboldt and others added 17 commits February 19, 2025 15:38
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…eloper#2388)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…oper#2394)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update basic-authentication.spec.ts

* Update github-provider.spec.ts

* Update microsoft-provider.spec.ts
redhat-developer#2248)

* Add temporary plugin configurations for sandbox setup

* Add sanity plugins check to pipeline scripts and tests

Signed-off-by: Gustavo Lira <[email protected]>

* Remove default JOB_NAME export from CI test script

Signed-off-by: Gustavo Lira <[email protected]>

* Add audit log tests and remove commented-out config

Signed-off-by: Gustavo Lira <[email protected]>

* Refactor periodic sanity plugin checks deployment logic

Moved plugin checks deployment logic to a reusable function `initiate_sanity_plugin_checks_deployment`. Simplified the `run_sanity_plugins_check` method by delegating complex deployment steps to the new function, improving readability and maintainability.

Signed-off-by: Gustavo Lira <[email protected]>

---------

Signed-off-by: Gustavo Lira <[email protected]>
…redhat-developer#2390)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…at-developer#2383)

* Update audit log messages for e2e tests.

Signed-off-by: Gustavo Lira <[email protected]>

* Refactor audit log tests to improve readability

Signed-off-by: Gustavo Lira <[email protected]>

* Update e2e test for scaffolder logs and streamline validations

Signed-off-by: Gustavo Lira <[email protected]>

* Update e2e test for scaffolder logs and streamline validations

Signed-off-by: Gustavo Lira <[email protected]>

* Add "Queued" status to security scan regex

Signed-off-by: Gustavo Lira <[email protected]>

* Refactor regex formatting in Quay utility function.

Signed-off-by: Gustavo Lira <[email protected]>

* Enhance clickById method with wait for attached state.

Updated the clickById method to ensure the element is attached before attempting a click. This improves reliability by ensuring the element is present in the DOM when interacting with it.

Signed-off-by: Gustavo Lira <[email protected]>

* Update regex to include Medium and Low security scan statuses

Signed-off-by: Gustavo Lira <[email protected]>

* Simplify security scan test logic in Quay spec.

Removed conditional checks and unnecessary branching in the "Check Security Scan details" test. The new implementation directly verifies the scan cells in the table.

Signed-off-by: Gustavo Lira <[email protected]>

* Simplified the argument structure in the `verifyCellsInTable` function call by removing unnecessary line breaks.

Signed-off-by: Gustavo Lira <[email protected]>

* Update Quay security scan test to use visibility check

Signed-off-by: Gustavo Lira <[email protected]>

* Update Quay security scan test to use visibility check

Signed-off-by: Gustavo Lira <[email protected]>

---------

Signed-off-by: Gustavo Lira <[email protected]>
…at-developer#2263)

* feat(global-header): added config for default header components

Signed-off-by: Yi Cai <[email protected]>

* prettier fix

Signed-off-by: Yi Cai <[email protected]>

* hide header items in sidebar

Signed-off-by: Yi Cai <[email protected]>

* resolve failed ci checks

Signed-off-by: Yi Cai <[email protected]>

* resolve failed ci checks

Signed-off-by: Yi Cai <[email protected]>

* updated header component mp name

Signed-off-by: Yi Cai <[email protected]>

* added icons and updated global header config

Signed-off-by: Yi Cai <[email protected]>

* addressed review comments

Signed-off-by: Yi Cai <[email protected]>

* updated global header wrapper to take the latest release

Signed-off-by: Yi Cai <[email protected]>

* removed default support button url

Signed-off-by: Yi Cai <[email protected]>

* resolved merging conflicts

Signed-off-by: Yi Cai <[email protected]>

* addressed review comments

Signed-off-by: Yi Cai <[email protected]>

* updated theme package to pick up changes for global header

Signed-off-by: Yi Cai <[email protected]>

* fix: align application header mountpoint with other mount points

Signed-off-by: Christoph Jerolimov <[email protected]>

* fixed double scrollbar issue

Signed-off-by: Yi Cai <[email protected]>

* small pickup

Signed-off-by: Yi Cai <[email protected]>

* prettier fix

Signed-off-by: Yi Cai <[email protected]>

* updated default global header config

Signed-off-by: Yi Cai <[email protected]>

* fixed global header version

Signed-off-by: Yi Cai <[email protected]>

* fixed default global header config

Signed-off-by: Yi Cai <[email protected]>

* updated header package.json dependency

Signed-off-by: Yi Cai <[email protected]>

* ignore the problematic link

Signed-off-by: Yi Cai <[email protected]>

* updated yarn.lock

Signed-off-by: Yi Cai <[email protected]>

* code clean

Signed-off-by: Yi Cai <[email protected]>

* code clean

Signed-off-by: Yi Cai <[email protected]>

* added config to hide search and settings when header is enabled

Signed-off-by: Yi Cai <[email protected]>

* feat(global-header): use global-header 1.0.0

* feat(global-header): add optional layout config option for the header itself

* docs(global-header): small fix

* feat(global-header): enable new global-header plugin by default

* fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637)

* chore(global-header): disable header in e2e tests for now

* fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637)

* fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637)

* fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637)

* hide notifications from sidebar by default

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Co-authored-by: Christoph Jerolimov <[email protected]>
@zdrapela zdrapela force-pushed the operator-version-based-on-branch branch from afef3af to 1a44aaf Compare February 19, 2025 14:38
@zdrapela zdrapela closed this Feb 19, 2025
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants