Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add marketplace/extension catalog entities #2494

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Mar 4, 2025

Description

This adds the first set of marketplace catalog entities to RHDH container image.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Start the container image and add the bundled catalog locations to your setup:

upstream:
  backstage:
    image:
      registry: quay.io
      repository: rhdh-community/rhdh
      tag: pr-2494
      pullPolicy: IfNotPresent

    appConfig:
      catalog:
        rules:
          - allow: [Component, System, API, Resource, Location, PluginCollection, Plugin, Package]
        locations:
          - type: file
            target: /marketplace/catalog-entities/plugins/all.yaml
            rules:
              - allow: [Location, Plugin]
          - type: file
            target: /marketplace/catalog-entities/packages/all.yaml
            rules:
              - allow: [Location, Package]

Copy link
Contributor

github-actions bot commented Mar 4, 2025

@christoph-jerolimov christoph-jerolimov force-pushed the marketplace/add-catalog-entities branch from 34106a0 to b689d25 Compare March 4, 2025 15:28
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Copy link
Contributor

github-actions bot commented Mar 4, 2025

@christoph-jerolimov christoph-jerolimov marked this pull request as ready for review March 5, 2025 12:42
@christoph-jerolimov christoph-jerolimov changed the title [WIP] chore: add marketplace catalog entities chore: add marketplace/extension catalog entities Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

@christoph-jerolimov christoph-jerolimov force-pushed the marketplace/add-catalog-entities branch from 0d632c4 to a0d5af3 Compare March 5, 2025 23:54
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@invincibleJai
Copy link
Member

/retest

@invincibleJai
Copy link
Member

/lgtm

Thanks @christoph-jerolimov , Have tested this on cluster, could see 60 plugins

image

@kadel can we get this merged?

cc @karthikjeeyar

@invincibleJai
Copy link
Member

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@invincibleJai invincibleJai force-pushed the marketplace/add-catalog-entities branch from a0d5af3 to 673ca68 Compare March 6, 2025 12:19
@openshift-ci openshift-ci bot removed the lgtm label Mar 6, 2025
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@kadel
Copy link
Member

kadel commented Mar 6, 2025

/test e2e-tests

@openshift-ci openshift-ci bot removed the lgtm label Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@kadel
Copy link
Member

kadel commented Mar 6, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 6, 2025
Copy link

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, kadel, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [invincibleJai,kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c5dca7e into redhat-developer:main Mar 6, 2025
15 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: new pull request created: #2527

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants