Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): rhidp-6351 Update Dockerfile, workflows, and scripts for Yarn support #2543

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

gustavolira
Copy link
Contributor

@gustavolira gustavolira commented Mar 11, 2025

Switch Docker build context to project root and integrate .yarnrc.yml to specify Yarn version. Modify workflows and .dockerignore to accommodate the new build context and ensure .yarnrc.yml is included. Add error handling for Yarn installation in utils.sh to improve debugging.

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from dzemanov and nilgaar March 11, 2025 12:54
Copy link

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gustavolira. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copy link
Contributor

Added an additional image tag including the short SHA to improve traceability in the GitHub workflow. Upgraded the `opm` version in the Dockerfile from 1.23.0 to 1.47.0

Signed-off-by: Gustavo Lira <[email protected]>
@nickboldt nickboldt merged commit da3b2f2 into redhat-developer:main Mar 11, 2025
9 of 12 checks passed
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants