-
Notifications
You must be signed in to change notification settings - Fork 211
chore(e2e): update existing scorecard e2e #3921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(e2e): update existing scorecard e2e #3921
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
af3f3df to
535c9d0
Compare
535c9d0 to
f670716
Compare
|
The image is available at: /test e2e-ocp-helm |
|
/retest |
|
Hi @HusneShabbir thanks for this PR. I'm sorry but the current (old?) scorecard tests are so flaky that I disabled them with #3925 again. I created ticket https://issues.redhat.com/browse/RHDHBUGS-2444 for this. Can you pick this up and solve this with this issue here together? But for that, you must of course re-enable the tests (again) and imho the tests should pass 3, better 5, times. So I mark this on hold until someone verified that this here is really an improvement OR we improved and re-eanbled the tests with another PR. Without running the tests I don't think we should merge this. /hold |
|
|
/retest |
|
The image is available at: /test e2e-ocp-helm |
|
/retest |
|
@HusneShabbir: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The flakyness is fixed but it looks like you need to rebase your PR and fix the updated tests. Feel free to remove the hold when it passes. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |



PR Description
Title: Migrate Scorecard E2E tests from mocked to real backend
Which issue(s) does this PR fix
Fixes RHIDP-10938
Summary
Replaced mocked API responses with real-time backend integration for scorecard plugin tests.
What Changed
importAndOpenScorecard()helper to reduce code duplicationDeleted Files
scorecard-utils.tsscorecard-response-utils.ts