Skip to content

Conversation

@HusneShabbir
Copy link
Contributor

@HusneShabbir HusneShabbir commented Dec 16, 2025

PR Description

Title: Migrate Scorecard E2E tests from mocked to real backend

Which issue(s) does this PR fix

Fixes RHIDP-10938

Summary

Replaced mocked API responses with real-time backend integration for scorecard plugin tests.

What Changed

  • Real backend testing - Tests now validate against live scorecard API instead of mocked responses
  • New tests - Added single scorecard visibility tests (GitHub-only, Jira-only)
  • Refactored - Added importAndOpenScorecard() helper to reduce code duplication
  • Cleanup - Removed unused mock utilities and methods

Deleted Files

  • scorecard-utils.ts
  • scorecard-response-utils.ts

@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign subhashkhileri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@HusneShabbir
Copy link
Contributor Author

/retest

@christoph-jerolimov
Copy link
Member

Hi @HusneShabbir thanks for this PR. I'm sorry but the current (old?) scorecard tests are so flaky that I disabled them with #3925 again.

I created ticket https://issues.redhat.com/browse/RHDHBUGS-2444 for this. Can you pick this up and solve this with this issue here together?

But for that, you must of course re-enable the tests (again) and imho the tests should pass 3, better 5, times. So I mark this on hold until someone verified that this here is really an improvement OR we improved and re-eanbled the tests with another PR. Without running the tests I don't think we should merge this.

/hold

@sonarqubecloud
Copy link

@HusneShabbir
Copy link
Contributor Author

/retest

@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@HusneShabbir
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2025

@HusneShabbir: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 93284be link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@christoph-jerolimov
Copy link
Member

The flakyness is fixed but it looks like you need to rebase your PR and fix the updated tests.

Feel free to remove the hold when it passes.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@HusneShabbir
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants