-
Notifications
You must be signed in to change notification settings - Fork 211
feat(i18n): added fr, it and ja support #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(i18n): added fr, it and ja support #3935
Conversation
|
|
The image is available at: /test e2e-ocp-helm |
|
/cc @redhat-developer/rhdh-ui |
|
@christoph-jerolimov: Overrode contexts on behalf of christoph-jerolimov: SonarCloud Code Analysis DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
karthikjeeyar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @ciiay, I have a minor suggestion
Since you are changing the naming convention from sprint based identifiers to date based identifiers, can we also drop -C suffix (which is added by TMS). This way it becomes easy for anyone who contributes a new translations with their own translations system.
Format: <source-name>-reference-<YYYY-MM-DD>-<locale>.json
move this rhdh-plugins-reference-2025-12-05-ja-C.json to rhdh-plugins-reference-2025-12-05-ja.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file and ja translation files contains only a limited set of translated strings compared to french, are we waiting for second batch of strings to be translated ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karthikjeeyar , thanks for the review 🤝 I see what was missing from the new version. My tooling commands only scanned:
- RHDH TypeScript translation files (packages/app/src/translations/**/*.ts)
- Not the Backstage plugin translation refs
- Not the JSON override files that contain plugin translations
It should be safe to merge this PR now, and I'm uploading a patch for the rest of references to TMS project for translation of it and ja. We should still make it for the code freeze.
cc. @invincibleJai
karthikjeeyar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can bring in a second batch of strings to cover all the missing key/value pairs once the translation team completes it.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: karthikjeeyar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |


Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer