Skip to content

Conversation

@ciiay
Copy link
Member

@ciiay ciiay commented Dec 19, 2025

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

The image is available at:

/test e2e-ocp-helm

@christoph-jerolimov
Copy link
Member

/cc @redhat-developer/rhdh-ui
/override "SonarCloud Code Analysis"

@openshift-ci openshift-ci bot requested review from a team, invincibleJai and rohitkrai03 and removed request for a team December 19, 2025 10:01
@openshift-ci
Copy link

openshift-ci bot commented Dec 19, 2025

@christoph-jerolimov: Overrode contexts on behalf of christoph-jerolimov: SonarCloud Code Analysis

Details

In response to this:

/cc @redhat-developer/rhdh-ui
/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christoph-jerolimov christoph-jerolimov requested a review from a team December 19, 2025 10:01
Copy link
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @ciiay, I have a minor suggestion

Since you are changing the naming convention from sprint based identifiers to date based identifiers, can we also drop -C suffix (which is added by TMS). This way it becomes easy for anyone who contributes a new translations with their own translations system.

Format: <source-name>-reference-<YYYY-MM-DD>-<locale>.json

move this rhdh-plugins-reference-2025-12-05-ja-C.json to rhdh-plugins-reference-2025-12-05-ja.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file and ja translation files contains only a limited set of translated strings compared to french, are we waiting for second batch of strings to be translated ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karthikjeeyar , thanks for the review 🤝 I see what was missing from the new version. My tooling commands only scanned:

  1. RHDH TypeScript translation files (packages/app/src/translations/**/*.ts)
  2. Not the Backstage plugin translation refs
  3. Not the JSON override files that contain plugin translations

It should be safe to merge this PR now, and I'm uploading a patch for the rest of references to TMS project for translation of it and ja. We should still make it for the code freeze.

cc. @invincibleJai

Copy link
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can bring in a second batch of strings to cover all the missing key/value pairs once the translation team completes it.

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karthikjeeyar
Once this PR has been reviewed and has the lgtm label, please assign alizard0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants