chore(e2e): remove remaining migrated plugin tests and CI infrastructure#4898
Conversation
|
The container image build workflow finished with status: |
|
/test e2e-ocp-helm-nightly |
|
/hold till redhat-developer/rhdh-plugin-export-overlays#1972 is merged |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4898 +/- ##
==========================================
- Coverage 55.82% 55.25% -0.58%
==========================================
Files 121 109 -12
Lines 2350 2132 -218
Branches 563 536 -27
==========================================
- Hits 1312 1178 -134
+ Misses 1033 953 -80
+ Partials 5 1 -4
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/test e2e-ocp-helm-nightly |
|
The bulk import tests have been migrated successfully redhat-developer/rhdh-plugin-export-overlays#2500 |
|
@teknaS47: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
/retest |
openshift-merge-bot
Bot
merged commit f81f3f0
into
redhat-developer:main
|
/cherrypick release-1.10 |
|
@teknaS47: #4898 failed to apply on top of branch "release-1.10": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The orchestrator E2E tests and their page objects were migrated out of this repo (PR #4898) to redhat-developer/rhdh-plugin-export-overlays. This 3-line "Workflows" table page object was left behind and is imported by no spec or support file. Remove the dead code. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 participants
Summary
Jira: RHIDP-13952
Tests Removed
failswitch-workflow.spec.ts,greeting-workflow.spec.ts,orchestrator-rbac.spec.ts,orchestrator-entity-rbac.spec.ts,orchestrator-entity-workflows.spec.ts,retry-workflow.spec.ts,token-propagation-workflow.spec.ts,ui-props-test-workflow.spec.ts,workflow-all-runs-validations.spec.ts,orchestrator.ts(page object),orchestrator-rbac-helper.ts(API helper)values_showcase.yaml+values_showcase-rbac.yaml;orchestrator:SonataFlow config sections; entity-workflow templates fromapp-config-rhdh.yaml+app-config-rhdh-rbac.yaml;- orchestratorfrompluginsWithPermission; full "Orchestrator Entity-Workflow RBAC" section fromrbac-policy.csv;testIgnoreentries from 6 Playwright projects; orchestrator disable overrides from 6diff-values_showcase*.yamlfilesbulk-import.spec.ts,bulk-import.ts(page object),bulk-import.ts(test data)values_showcase.yaml+values_showcase-rbac.yaml;bulkImport:config + catalog URL fromapp-config-rhdh-rbac.yaml;bulk_importrole fromrbac-policy.csv,rbac-constants.ts, andauthentication-providers/yamls/rbac-policy.csv;testIgnoreentries from Playwright configextensions.spec.ts,extensions.ts(page object)values_showcase.yaml+values_showcase-rbac.yaml;extensions:config fromapp-config-rhdh.yaml;extensionrole fromrbac-policy.csv+rbac-constants.ts;extensions-catalogvolume mount + volume fromvalues_showcase-rbac.yaml+ 6diff-values_showcase-rbac_*.yamlfilesCI Infrastructure Removed
.ci/pipelines/lib/orchestrator.sh— entire file deleted (SonataFlow deployment, workflow management, plugin enablement functions).ci/pipelines/lib/operators.sh— removedoperator::install_serverless_logic()andoperator::install_serverless()(SonataFlow/Knative operator installs).ci/pipelines/utils.sh— removed all orchestrator delegation functions (should_skip_orchestrator,deploy_orchestrator_workflows,enable_orchestrator_plugins_op,install_orchestrator_infra_chart,disable_orchestrator_plugins_in_values); simplifiedbase_deployment(),rbac_deployment(),cluster_setup_ocp_helm(),cluster_setup_ocp_operator()by removing orchestrator conditional logic; removed serverless operator installs fromcluster_setup_ocp_operator().ci/pipelines/jobs/upgrade.sh— removeddeploy_orchestrator_workflowscall.ci/pipelines/jobs/ocp-operator.sh— removed commented-out orchestrator deployment calls and "(orchestrator disabled)" log messages.ci/pipelines/jobs/ocp-nightly.sh— removed "(orchestrator disabled)" log messagesdiff-values_showcase_PR.yaml,diff-values_showcase-rbac_PR.yaml,diff-values_showcase_upgrade.yaml,diff-values_showcase_OSD-GCP.yaml,diff-values_showcase-rbac_OSD-GCP.yaml— cleared orchestrator override contentdiff-values_showcase-sanity-plugins.yaml— removedorchestrator: enabledsectiondiff-values_showcase_{AKS,EKS,GKE}.yaml— removed orchestrator plugin disable entries andorchestrator: nulldiff-values_showcase-rbac_{AKS,EKS,GKE}.yaml— removed orchestrator plugin disable entries,extensions-catalogvolume mounts/volumes, andorchestrator: nullDocumentation Updated
docs/e2e-tests/CI-medic-guide.md— removed 5 stale references to orchestrator infrastructure,orchestrator.sh, and orchestrator workflow steps.ci/pipelines/lib/README.md— removedorchestrator.shmodule section and stale serverless function referencesShared Dependencies Preserved
backstage-community-plugin-catalog-backend-module-keycloak-dynamic) kept — still required by remaining testscatalog.providers.keycloakOrgkept in both app-config filesKEYCLOAK_AUTH_*env vars kept — used by OIDC auth providerrbac-api.ts,rbac.ts,rbac-constants.ts,rhdh-auth-api-hack.ts) kept — still used byauditor-rbac.spec.tsand other remaining testshome-page-customization.spec.tsretained with Quick Access verificationTest plan
showcase+showcase-rbac) — validates deployment with removed plugins and remaining tests passshowcase-sanity-plugins, localization, and runtimeshowcase-operator+showcase-operator-rbac