[release-1.9] fix(e2e): fix orchestrator workflow deployment

[rostalan]

Description

On 1.9, orchestrator tests fail with timeout error, because workflow images do not exist.
This PR changes OSL channel from logic-operator-rhel8:alpha to logic-operator:stable and pins it to 1.37.2.
It also pins workflow images to 1.37.
And also unskips some skipped orchestrator jobs for 1.9.
And it also removes check for non-existing UI element that failed the tests (RHDHBUGS-3363)

Which issue(s) does this PR fix

Fixes RHDHBUGS-3383
Also fixes RHDHBUGS-3363

PR acceptance criteria

Please make sure that the following steps are complete:

• GitHub Actions are completed and successful
• Unit Tests are updated and passing
• E2E Tests are updated and passing
• Documentation is updated if necessary (requirement for new features)
• Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[github-actions]

Image was built and published successfully. It is available at:

• quay.io/rhdh-community/rhdh:pr-4979
• quay.io/rhdh-community/rhdh:pr-4979-a7f88ecf

[rostalan]

/test all

[rostalan]

/retest

[rostalan]

/test e2e-ocp-helm

[lholmquist]

@rostalan i recently push updated images for these four workflows and tagged them as osl_1_38

• serverless-workflow-greeting
• serverless-workflow-sample-retry-test
• serverless-workflow-test-object-type-uiprops
• fail-switch

i'm not sure if those are the workflows that were timing out or not. i know there was another slack thread that mentioned those

[rostalan]

@rostalan i recently push updated images for these four workflows and tagged them as osl_1_38

* [serverless-workflow-greeting](https://quay.io/repository/orchestrator/serverless-workflow-greeting)

* [serverless-workflow-sample-retry-test](https://quay.io/repository/orchestrator/serverless-workflow-sample-retry-test)

* [serverless-workflow-test-object-type-uiprops](https://quay.io/repository/orchestrator/serverless-workflow-test-object-type-uiprops)

* [fail-switch](https://quay.io/repository/orchestrator/fail-switch)

i'm not sure if those are the workflows that were timing out or not. i know there was another slack thread that mentioned those

Hey @lholmquist, thanks,
I am not sure this helps here, since the release-1.9 branch is still using osl 1.36.1 (via alpha channel of logic-operator-rhel8) and the decision was made yesterday to pin it to 1.37.

It might however have an impact for main and 1.10, where we are currently resolving to osl 1.38 afaik.
Not sure if there are any guards/warnings in place against using older workflow images (probably no?) and not sure how compatible the older images are with newer osl, since we keep seeing a lot of orchestrator related failures recently.

Will update this PR to pin the osl version to 1.37.2.

[github-actions]

The container image build workflow finished with status: cancelled.

[github-actions]

Image was built and published successfully. It is available at:

• quay.io/rhdh-community/rhdh:pr-4979
• quay.io/rhdh-community/rhdh:pr-4979-1b968895

[polasudo]

CI Medic: Root Cause Analysis

The pull-ci-redhat-developer-rhdh-release-1.9-e2e-ocp-helm job failed before any tests ran.

Root cause: .ci/pipelines/utils.sh line 381 references bare $7 (starting_csv=$7) but 4 of 5 callers of install_subscription() only pass 6 arguments. With set -o nounset (set in openshift-ci-tests.sh line 5), this is a fatal "unbound variable" error.

The crash happened during OpenShift Pipelines operator installation (install_pipelines_operator at line 968), which calls install_subscription with only 6 args.

Callers affected:

Line	Caller	Args
457	install_crunchy_postgres_ocp_operator	6 (crashes)
480	install_crunchy_postgres_k8s_operator	6 (crashes)
503	install_serverless_logic_ocp_operator	7 (OK)
513	install_serverless_ocp_operator	6 (crashes)
968	install_pipelines_operator	6 (crashes)

Fix: Change line 381 from:

starting_csv=$7

to:

starting_csv=${7:-}

This makes the 7th parameter optional with an empty default, which is the correct behavior since only the serverless logic operator needs CSV pinning.

[github-actions]

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

[github-actions]

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

[github-actions]

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

[github-actions]

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

[github-actions]

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

[github-actions]

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

[github-actions]

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

[rostalan]

/test e2e-ocp-helm

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud