Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e-tests) Test for dynamic-plugins-info #971

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

gashcrumb
Copy link
Member

@gashcrumb gashcrumb commented Feb 15, 2024

This change adds a E2E test for the dynamic plugins info frontend plugin that validates the plugin mounts at the expected location in the app and checks basic functionality.

For RHIDP-1005

This e2e test can be tested against a local instance:

  • Install the dynamic-plugins-info plugin into your backstage-showcase clone's local dynamic-plugins-root
  • Start up the backstage-showcase app
  • In a 2nd console, cd into e2e-tests and run BASE_URL=http://localhost:3000 npx playwright test --ui (substitute the hostname as needed)

In the playwright UI run the dynamic-plugins-info test.

Note: There's an existing dynamic-plugins-info-backend test (renamed in this PR) that requires a specific setup and won't run locally.

@gashcrumb gashcrumb requested a review from a team as a code owner February 15, 2024 16:22
Copy link

changeset-bot bot commented Feb 15, 2024

⚠️ No Changeset found

Latest commit: 1c74cbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-971!

Copy link
Contributor

janus-idp bot commented Feb 15, 2024

backstage-showcase Tests on commit 15e2f4e finished successfully.
View test log

@gashcrumb
Copy link
Member Author

@subhashkhileri this probably needs the dynamic-plugins-info frontend plugin to be enabled in the app for the test to pass. Where is that set up?

@subhashkhileri
Copy link
Member

@gashcrumb

@subhashkhileri this probably needs the dynamic-plugins-info frontend plugin to be enabled in the app for the test to pass. Where is that set up?

Here is the plugins config: https://github.com/janus-idp/backstage-showcase/blob/main/.ibm/pipelines/value_files/values_showcase.yaml#L14

@gashcrumb
Copy link
Member Author

Awesome thanks! Updated that, let's see how it goes...

This change adds a E2E test for the dynamic plugins info frontend plugin
that validates the plugin mounts at the expected location in the app and
checks basic functionality.

Signed-off-by: Stan Lewis <[email protected]>
@gashcrumb gashcrumb marked this pull request as draft February 19, 2024 13:08
@gashcrumb
Copy link
Member Author

This is not running locally now for me this morning after a rebase, looking into that.

@gashcrumb gashcrumb marked this pull request as ready for review February 19, 2024 14:12
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gashcrumb
Copy link
Member Author

This is not running locally now for me this morning after a rebase, looking into that.

Ah, APP_BASE is now BASE_URL, easy fix 😄

@gashcrumb
Copy link
Member Author

Hmm:

image

@subhashkhileri
Copy link
Member

/lgtm

@invincibleJai
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c143d99 into redhat-developer:main Feb 20, 2024
7 checks passed
kadel pushed a commit to kadel/backstage-showcase that referenced this pull request Feb 20, 2024
This change adds a E2E test for the dynamic plugins info frontend plugin
that validates the plugin mounts at the expected location in the app and
checks basic functionality.

Signed-off-by: Stan Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants